Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trivial deps #335

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

workingjubilee
Copy link

While bcachefs-tools makes good use of many dependencies that have nontrivial code in them, byteorder and memoffset are easily replaced with standard library code nowadays.

A trivial replacement allowed by std stabilizing it in rust 1.77.
Less crate dependencies means less odd decisions by packagers.
This requires something other than literally zero code to replace, but
is another opportunity to deny packagers the fun of experimenting with
replacing crate versions with incompatible patched crate versions.
@workingjubilee
Copy link
Author

The byteorder patch doesn't require an MSRV bump, for note.

@koverstreet koverstreet merged commit 68704c3 into koverstreet:master Sep 4, 2024
@workingjubilee workingjubilee deleted the remove-trivial-deps branch September 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants