-
Notifications
You must be signed in to change notification settings - Fork 0
Add engine for side-by-side execution option at command diff (-y) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix(deps): update rust crate regex to v1.11.1
chore(deps): update rust crate tempfile to v3.14.0
…dows Fix "unused import" warning on Windows
…tion ci: remove `CARGO_FEATURES_OPTION`
…tion-5.x chore(deps): update codecov/codecov-action action to v5
ci: make sure gpatch is actually being used for tests on MacOS
fix(deps): update rust crate itoa to v1.0.15
fix(deps): update rust crate chrono to v0.4.40
…kfile chore(deps): update rust crate predicates to v3.1.3
chore(deps): update rust crate tempfile to v3.17.1
chore(deps): update rust crate tempfile to v3.18.0
chore(deps): update rust crate tempfile to v3.19.0
chore(deps): update rust crate tempfile to v3.19.1
…kfile chore(deps): update rust crate assert_cmd to v2.0.17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good =) a few more suggestions.
- Now, the limited_string function only accepts &[u8] as the original parameter, because we are working with possible long strings and the as_ref call can become a possible cause of a mem leak. - Now, the return type is a ref to the original slice. This is done cause is unnescessary to create a new vec![]
…lit_lines. This was done to improve code readability and follow standards written by other devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these two small comments I think I am happy and you got some practice ;D. Time to get a real review and deal with the real maintainer's comments.
That was an interesting experience, let's see what they think : ) |
Add -y (or --side-by-side) option to sdiff command to allow viewing of file in side by side mode. This is also the base engine for sdiff command.