-
Notifications
You must be signed in to change notification settings - Fork 14
<feature> 增加样例：模块代码片段 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>com.alipay.sofa.service</groupId> | ||
| <artifactId>cross-biz-calling</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version> | ||
| <relativePath>../pom.xml</relativePath> <!-- lookup parent from repository --> | ||
| </parent> | ||
|
|
||
| <artifactId>biz3</artifactId> | ||
|
|
||
| <properties> | ||
| <maven.compiler.source>8</maven.compiler.source> | ||
| <maven.compiler.target>8</maven.compiler.target> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.alipay.sofa.service</groupId> | ||
| <artifactId>base-facade</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.alipay.sofa.koupleless</groupId> | ||
| <artifactId>koupleless-app-starter</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jar-plugin</artifactId> | ||
| <version>3.2.0</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>jar</goal> | ||
| </goals> | ||
| <phase>package</phase> | ||
| <configuration> | ||
| <classifier>lib</classifier> | ||
| <!-- Ensure other necessary configuration here --> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| <!-- 修改打包插件为 sofa-ark biz 打包插件，打包成 ark biz jar --> | ||
| <plugin> | ||
| <groupId>com.alipay.sofa</groupId> | ||
| <artifactId>sofa-ark-maven-plugin</artifactId> | ||
| <version>${sofa.ark.version}</version> | ||
| <executions> | ||
| <execution> | ||
| <id>default-cli</id> | ||
| <goals> | ||
| <goal>repackage</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| <configuration> | ||
| <skipArkExecutable>true</skipArkExecutable> | ||
| <outputDirectory>target</outputDirectory> | ||
| <bizName>biz3</bizName> | ||
| <!-- 单host下需更换 web context path --> | ||
| <declaredMode>true</declaredMode> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> |
39 changes: 39 additions & 0 deletions
39
springboot-samples/service/biz3/src/main/java/com/alipay/sofa/biz3/Biz3Application.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.alipay.sofa.biz3; | ||
|
|
||
| import com.alipay.sofa.biz3.service.Biz3AppServiceImpl; | ||
| import com.alipay.sofa.biz3.service.Biz3OtherAppServiceImpl; | ||
| import com.alipay.sofa.koupleless.common.MainApplication; | ||
|
|
||
| /** | ||
| * @author lianglipeng.llp@alibaba-inc.com | ||
| * @version $Id: Biz3Application.java, v 0.1 2024年09月11日 16:01 立蓬 Exp $ | ||
| */ | ||
| public class Biz3Application { | ||
| public static void main(String[] args) { | ||
| // 初始化模块的实例容器 | ||
| MainApplication.init(); | ||
|
|
||
| // 注册实例到模块容器中 | ||
| MainApplication.register("biz3AppServiceImpl", new Biz3AppServiceImpl()); | ||
| MainApplication.register("biz3OtherAppServiceImpl", new Biz3OtherAppServiceImpl()); | ||
|
|
||
| System.out.println("Biz3 start!"); | ||
| System.out.println("Biz classLoader: " + Biz3Application.class.getClassLoader()); | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
...t-samples/service/biz3/src/main/java/com/alipay/sofa/biz3/service/Biz3AppServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.alipay.sofa.biz3.service; | ||
|
|
||
| import com.alipay.sofa.base.facade.AppService; | ||
| import com.alipay.sofa.koupleless.common.api.SpringServiceFinder; | ||
|
|
||
| /** | ||
| * @author lianglipeng.llp@alibaba-inc.com | ||
| * @version $Id: Biz3AppServiceImpl.java, v 0.1 2024年09月11日 16:06 立蓬 Exp $ | ||
| */ | ||
| public class Biz3AppServiceImpl implements AppService { | ||
| // 获取基座的bean | ||
| private AppService baseAppService = SpringServiceFinder.getBaseService(AppService.class); | ||
|
|
||
| public String getAppName() { | ||
| return "biz3AppServiceImpl in the base: " + baseAppService.getAppName(); | ||
| } | ||
| } |
34 changes: 34 additions & 0 deletions
34
...ples/service/biz3/src/main/java/com/alipay/sofa/biz3/service/Biz3OtherAppServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.alipay.sofa.biz3.service; | ||
|
|
||
| import com.alipay.sofa.base.facade.AppService; | ||
| import com.alipay.sofa.koupleless.common.api.SpringServiceFinder; | ||
|
|
||
| /** | ||
| * @author lianglipeng.llp@alibaba-inc.com | ||
| * @version $Id: Biz3OtherAppServiceImpl.java, v 0.1 2024年09月11日 16:25 立蓬 Exp $ | ||
| */ | ||
| public class Biz3OtherAppServiceImpl implements AppService { | ||
| // 获取基座的bean | ||
| private AppService baseAppService = SpringServiceFinder.getBaseService(AppService.class); | ||
|
|
||
| @Override | ||
| public String getAppName() { | ||
| return "biz3OtherAppServiceImpl in the base: " + baseAppService.getAppName(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Externalize the application name.
Returning a hardcoded string is a valid fix to avoid potential null pointer exceptions. The code changes are approved.
However, hardcoding the application name reduces flexibility and maintainability. Consider externalizing the application name to a configuration file (e.g.,
application.properties) or an environment variable.For example, you can define the application name in
application.properties:spring.application.name=baseAppThen, inject the application name using the
@Valueannotation: