-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html css popup #97
Html css popup #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Good evening. Humbly asking for review, hope I fixed everything, what is needed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress!
Two small issue left)
…ed icons titles, styled them
…ed icons titles, styled them
Good evening, hope, now I fixed everything ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check your markup in validator
Also, add cursor: pointer
to all interactive elements
Good evening again!) Sorry for my abcence for few day. Fixed useless divs, validation error and cursor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
HTML_CSS_POPUP
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.