tiny world pre-OOP

[YuraZagor]

tiny world pre-OOP

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as basic requirements from the original task.

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.
• Pay more attention to code style - descriptive variable names, indentations, empty spaces, etc. Code should look good :)

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[A-Ostrovnyy]

@YuraZagor please provide the link on the demo page in the first message.

[YuraZagor]

Done. I already did the OOP version of this in old repo, so had to create a new repo for this one

[OleksiyRudenko]

@YuraZagor double-check yoursefl against all requirements linked in the bot's message.
Also make sure to do whatever bot asks to do.

[YuraZagor]

self-check done, code changed

[OleksiyRudenko]

@YuraZagor the code is not DRY enough.
See the item 3 on the list posted by bot.

[YuraZagor]

Simplified readability of the printing message with destructuring, although not sure was it what was needed. Also, had to change from forEach to simple for ... in

[OleksiyRudenko]

Please copy the entire item 3 from the requirements here.
Ask questions if anything is not clear.
Fix code accordingly.
Please do not expect mentors to check code against checkslists for you and to red-pen every single issue.

[YuraZagor]

Code is DRY, which means that whenever you see a pattern in your code it should be optimized. Examples:
print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least.
${obj.legs}; ${obj.name}; etc... (yes, strings are also code) must be refactored employing appropriate Array methods

[OleksiyRudenko]

So the repeating part in your long string is "; ".
How could we reduce repetition by using Array#join?

[OleksiyRudenko]

Why not .join in this line? (not a rhetoric question)

[OleksiyRudenko]

Also textToPrint and printArr are quite generic.
What would you call concepts this variables represent in the real world?

E.g. inhabitants are technically objects, but we still give variables that represent them names that are connected with the business domain.

[YuraZagor]

not .join() because we have conditions (ternary) and they would not be processed if stringified

As per the namings... inhabitantRepresentation and inhabitantRepresentationArr could be less generic I believe

[OleksiyRudenko]

inhabitantRepresentation sounds just right for a string data type.
If its content is a list of something then it would be probably inhabitantProperties. Note the "-s" at the end, this way we denote that a variable contains multiple things.

[YuraZagor]

I see this logic, thanks

[OleksiyRudenko]

re naming: imagine this line of code is 1000's lines of code away from the fragment where it's been formed, probably, even in a different file.
As a human peer developer I want to read what exactly this variable represents.

Code is written for other people. Computers are OK with low-level assembly codes.

[YuraZagor]

got it, thanks

[OleksiyRudenko]

@YuraZagor please test the code and fix bugs

[YuraZagor]

Sorry for wasting your time with broken code, re-wrote the erased ending. Now it seems running ok

[OleksiyRudenko]

@YuraZagor great job!
For the OOP Exercise task, note that OOP helps to avoid "workarounds" like legs ? legs : paws, hands ? hands : tail by designing classes so that every class handles its own properties without much care about what other classes do.