Classic Frogger Game #594

YuraZagor · 2022-09-17T14:27:00Z

Classic Frogger Game

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-17T16:24:50Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

In addition to the bot's suggestions above, please post a link to the app demo in Students' chat, collect feedback and fix bugs if any based on that. When user tests are done post here a comment on that.

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

YuraZagor · 2022-09-20T15:53:41Z

self-check done

OleksiyRudenko

@YuraZagor good start. Needs improvements and double-check against requirements.

OleksiyRudenko · 2022-09-26T10:26:03Z

submissions/YuraZagor/Frogger/app.js

@@ -0,0 +1,92 @@
+const allEnemies = [];
+const allSpeeds = [200, 250, 350];
+const rangeY = [73, 156, 239];


What are these magic numbers?
As a peer developer I am tasked to add another Y. How do I calculate it? Ideally I want to add a row number and let computer do what they were invented to do - calculations.
Also true for other numbers representing pixels across the entire codebase.

OleksiyRudenko · 2022-09-26T10:26:58Z

submissions/YuraZagor/Frogger/app.js

+            player.x = playerStartX;
+            player.y = playerStartY;


Item 4.iii of the requirements

OleksiyRudenko · 2022-09-26T10:28:31Z

submissions/YuraZagor/Frogger/app.js

+    )
+};
+
+player.handleInput = function (direction) {


One of the purposes of OOP is that class defines all behaviors of the class.
Please explain why this approach was taken.

My logic then was as follows: this kind of behavior is typical only to player object. As in this case we do not need this functionality in Player-prototyped enemy-objects , so I did not prototype it in Player.
Also, TBH, I am a newbie who tryed ways - and this one worked. Re-wrote with Player.prototype

this kind of behavior is typical only to player object
That's correct. Also true is that any method on Player prototype is typical to player object.

player.propertyName = function () worked, as expected. We still can have functions as object properties.

But what if we have a multiplayer game? OOP helps to have objects blue-prints and avoid code duplication.

Oh, I see. You based enemies on Player.
So in fact Player is an "any" character.

The good thing was that you came up with having a base class for shared properties and behaviour.
The improvemnt would be to have both Enemy and Player class extend such base class with their own specifics.
Are you up to improve your code accordingly?

yes, that way it makes more sense and now I was able to solve ' player.x = playerStartX' omitting .

Done

OleksiyRudenko

@YuraZagor a bit of wrong direction taken.
Check the difference between class and class instance.
Requirements provide a hint on how to resolve the issue.
Take a step back and try again.

OleksiyRudenko · 2022-10-02T09:01:46Z

submissions/YuraZagor/Frogger/app.js

+    if (this.y === Player.y){
+        if ((this.x - Player.x < collisionOffset ) && (Player.x - this.x < collisionOffset )) {
+            Player.x = playerStartX;
+            Player.y = playerStartY;
+        };    


Before we had here a reference to an instance of Player class stored in a global variable.
Now we directly refer here to the class itself.
Check the difference between class and an instance of a class.
Class is a blue-print. Enemies are intended to interact with specific instance (or instances in multiplayer mode) of Player class.
Also demo doesn't seem to work.

not sure that I fully understand it all, but as I get it I should pass the instance as an attribute, so that if we change the passed object we can still use the same method. Hope that was it

...pass the instance as an attribute...
As an argument. Just for the sake of correct use of terminology

OleksiyRudenko

@YuraZagor nearly there

OleksiyRudenko · 2022-10-02T16:14:44Z

submissions/YuraZagor/Frogger/app.js

+const spriteRepositioningY = -10
+const playerStartX = 2*cellX;
+const playerStartY = 5*cellY + spriteRepositioningY ;
+const fieldWidth = 5*cellX;
+const fieldHight = 5*cellY;
+const row1 = cellY + spriteRepositioningY
+const row2 = 2*cellY + spriteRepositioningY
+const row3 = 3*cellY + spriteRepositioningY


Why mixed style of semicolons usage?

My bad
Actually, I didn't have the habbit to use those before the course, and now I try to get used to them but at times I forget in haste

OleksiyRudenko · 2022-10-02T16:16:13Z

submissions/YuraZagor/Frogger/app.js

+const row1 = cellY + spriteRepositioningY
+const row2 = 2*cellY + spriteRepositioningY
+const row3 = 3*cellY + spriteRepositioningY
+const rangesY = [row1, row2, row3];


How about const rangesY = [1, 2, 3].map(some maths here)?
Whenever you are tempted to write var1, var2, var3 it is a clear sign that you need to create an array with some maths.

this is really great and concise, never thought that way. Done

OleksiyRudenko · 2022-10-02T16:17:45Z

submissions/YuraZagor/Frogger/app.js

+        this.x = enemyRestartX;
+        this.speedX = allSpeeds[Math.floor(Math.random()*3)];
+    };
+    this.checkColision(player)


checkCollision doesn't refer to global variable player, but now update does.
So the problem remains.
Feel free to ask specific questions to the hint from the requirement.
Yet another hint: there is a reason that you pass sprite by reference and do not refer to it directly.

I guess I finally got the point.
Though it is not clear how it works, will have to work on that - I mean as I see it passing instance as arg works even when player hasn't been created yet in the code

YuraZagor · 2022-10-03T15:04:41Z

self-check done
UAT done

OleksiyRudenko

@YuraZagor great job done!

OleksiyRudenko · 2022-10-05T13:43:53Z

submissions/YuraZagor/Frogger/app.js

+function addBug() {
+    rangesY.forEach ( (levelMark)=>  allEnemies
+    .push( new Enemy(0, levelMark, allSpeeds[Math.floor(Math.random()*3)], player)) 
+    )
+};


This wasn't a part of the requirements. But try to scale that narrow requirement onto a bigger scale.
A well designed function relies only on parameters it receives and doesn't refer to any global variables.
This way it encapsulates business logic it designated to implement.
In big codebases following this principle will pay.

YuraZagor added 2 commits September 17, 2022 17:22

minimum viable product

088a852

correcter switch case and added ;-s

a73ed68

YuraZagor changed the title ~~minimum viable product~~ Classic Frogger Game Sep 17, 2022

A-Ostrovnyy added the task-Frogger label Sep 17, 2022

added dimention constants

f268987

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

OleksiyRudenko added the OQ Open Question from reviewer requiring explanation label Sep 26, 2022

YuraZagor added 4 commits September 26, 2022 19:39

consts added + Player.prototype

997b6a7

const

d712661

collision separated

a7371b2

Character ancestor-class added

7dc2542

OleksiyRudenko added the Stage0.1 label Oct 1, 2022

OleksiyRudenko self-assigned this Oct 1, 2022

OleksiyRudenko requested changes Oct 2, 2022

View reviewed changes

added player passed as an attr

e7e9026

OleksiyRudenko requested changes Oct 2, 2022

View reviewed changes

YuraZagor added 7 commits October 2, 2022 20:45

;-s checked

f9dfa54

sprite variables added

8a06ad1

[1,2,3].map used

740cb0d

[1,2,3].map corrected

0ce02b9

player as arg to class Enemy

9bfab1d

bugs removed

26b074a

this.player

20d126f

OleksiyRudenko added UAT-done Student confirmed User Acceptance Tests are done and collected feedback is processed self-check-done Student confirmed that self-checks against requirements/common-mistakes are done labels Oct 5, 2022

OleksiyRudenko approved these changes Oct 5, 2022

View reviewed changes

OleksiyRudenko merged commit ac6b2a3 into kottans:main Oct 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Classic Frogger Game #594

Classic Frogger Game #594

YuraZagor commented Sep 17, 2022 •

edited

Loading

github-actions bot commented Sep 17, 2022

YuraZagor commented Sep 20, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 26, 2022

YuraZagor Sep 26, 2022

OleksiyRudenko Sep 26, 2022

OleksiyRudenko Sep 26, 2022

YuraZagor Sep 26, 2022

OleksiyRudenko Sep 26, 2022

YuraZagor Sep 26, 2022

OleksiyRudenko left a comment

OleksiyRudenko Oct 2, 2022

YuraZagor Oct 2, 2022

OleksiyRudenko Oct 2, 2022

OleksiyRudenko left a comment

OleksiyRudenko Oct 2, 2022

YuraZagor Oct 2, 2022

OleksiyRudenko Oct 2, 2022

YuraZagor Oct 2, 2022

OleksiyRudenko Oct 2, 2022

YuraZagor Oct 3, 2022 •

edited

Loading

YuraZagor commented Oct 3, 2022

OleksiyRudenko left a comment

OleksiyRudenko Oct 5, 2022

Classic Frogger Game #594

Classic Frogger Game #594

Conversation

YuraZagor commented Sep 17, 2022 • edited Loading