Building a Tiny JS World

[Dovahkiin1991]

Building a Tiny JS World

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as basic requirements from the original task.

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[Dovahkiin1991]

Hey, I made self-checks and all looks ok.

[OleksiyRudenko]

@Dovahkiin1991
Please copy all requirements re variable naming from all the materials linked by the bot and paste them as a comment, and fix code accordingly.

[Dovahkiin1991]

• Variable name should be camelCase.
• Variable names should not be too short or too obscure
• Variable names should not be too general.
• Functions denote actions hence their names should start with a verb. Variables containing strings, numbers, objects are normally nouns. Boolean variables/functions start with is, does, has etc. A variable containing multiple entities and functions returning lists contain entity name in plural form.

@OleksiyRudenko Made changes, according to this list.

[OleksiyRudenko]

@Dovahkiin1991 well done!

FYI, key is a term in programming domain. In real life living creatures are characterized by properties or features. One says "Purring is distinctive feature (or property) of felines" rather than "Purring is the distinctive key of felines".

So key is a generic term in the context of given business domain.