Js dom task #57
Merged
Js dom task #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonzujiro
approved these changes
Aug 5, 2022
|
@zonzujiro please review |
zonzujiro
requested changes
Aug 8, 2022
|
|
||
| asideList.addEventListener('click', function(event) { | ||
| const listTarget = event.target; | ||
| if (listTarget.tagName != 'LI') return; |
There was a problem hiding this comment.
Not sure why you need this check, TBH. What if I will click on the child of the list item?
There was a problem hiding this comment.
I added it because I can accidentally click on asideList itself which will cause error. Fixed
|
Please, resolve outdated conversations |
zonzujiro
reviewed
Aug 9, 2022
zonzujiro
approved these changes
Aug 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Js dom task
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.