OOP Tiny-JS-World #569
OOP Tiny-JS-World #569
Conversation
|
Hey! Congratulations on your PR! 😎😎😎 Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code. Go through the requirements/most common mistakes linked below and fix the code as appropriate. If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat. When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly. Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒 Please, make sure that your code follows the requirements based on the most common mistakes as well as both basic and advanced requirements from the original task. Universal recommendations:
By the way, you may proceed to the next task before this one is reviewed and merged. Sincerely yours, |
|
I've completed self-checks, did'nt find any common errors |
OleksiyRudenko
added
the
self-check-done
| this.saying = saying; | ||
| } | ||
| get tinyWorld() { | ||
| return `${this.species}; ${this.name}; ${this.gender}; ${this.saying}`; |
There was a problem hiding this comment.
Please employ Array methods. Starting array may not necessarily consist of strings. Actually, anything can be an array's element.
| get tinyWorld() { | ||
| return `${this.species}; ${this.name}; ${this.gender}; ${this.hands}; ${this.legs}; ${this.saying}`; |
There was a problem hiding this comment.
Use method overloading.
If we add a new universally shared property, current implementation will require changes to multiple classes' code. The point of encapsulation is that every class handles its own properties and re-uses inherited methods versions to build on top of whatever they provide us with.
Let's disregard the fact that we want to "insert" information about limbs before saying, for simplification.
|
Fixed this. Please, review |
oop-tiny-js-world
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.