askuznetsov html-css-popup #562

olkuznetsov · 2022-09-14T14:19:37Z

HTML-CSS-Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-15T07:15:19Z

Hey!

Congratulations on your PR! 😎😎😎

This PR contains irrelevant files.

You can see this under Files changed tab (you will find a couple of helpful tabs right under the PR title).

Most likely, you added all files from your project, not only required and sufficient code review as instructed in section B123 of submission instructions. Also read an important note therein.

Why we want only few files?

It helps code reviewers to focus on code you authored and have the workspace uncluttered with irrelevant images and transpiled files.
This keeps homeworks repository small.
For example, images add to the weight of the repo and will affect download/upload time for mentors and other students. We all care about others' time.

Please fix this issue by removing irrelevant files and add a comment stating that you did this.

Sincerely yours,
Submissions Kottachecker 😺

github-actions · 2022-09-15T07:15:21Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes.

In addition to the bot's suggestions above, please post a link to the app demo in Students' chat, collect feedback and fix bugs if any based on that. When user tests are done post here a comment on that.

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

olkuznetsov · 2022-09-15T19:49:25Z

Hello and thank you! I have deleted the images. It's only HTML, CSS, and SCSS files there.

olkuznetsov · 2022-09-15T19:51:26Z

Removed CSS file.

olkuznetsov · 2022-09-19T17:56:08Z

Fixed all errors and warnings in CSS

MaxKalashnyk

Great job! Take a look at my comments

MaxKalashnyk · 2022-09-19T19:00:03Z

submissions/askuznetsov/html-css-popup/style.scss

+    width: 33%;
+    margin-bottom: 24px;
+
+    &__link {


Please, add the default width of the border for this element because I see a layout shift when the user is trying to hover over this element. These styles should fix this issue:

border: 2px solid transparent;

MaxKalashnyk · 2022-09-19T19:01:23Z

submissions/askuznetsov/html-css-popup/index.html

+              />
+            </label>
+            <div class="popup">
+              <div class="arrow"></div>


You can also use pseudoelements for elements like this. It could simplify your layout

Sorry, what do you mean by like this? popup class? or arrow? anyway, I don't understand what exactly pseudoelement you admit here.

Instead of using additional elements in your layout, you can use pseudoelements

MaxKalashnyk · 2022-09-19T19:02:11Z

submissions/askuznetsov/html-css-popup/index.html

+                  <a href="#" class="menu__item__link">
+                    <img
+                      src="./popup-icons/calendar.png"
+                      alt=""


Don't forget to add the alt attribute for your images. Please, don't leave it empty

MaxKalashnyk · 2022-09-19T19:02:53Z

submissions/askuznetsov/html-css-popup/index.html

+              <label for="more__checkbox" class="more__checkbox__label"
+                >More...</label
+              >
+


You can use Prettier for formatting your files. It will make your code cleaner

That's what Prettier recommends. I am using default configs. I didn't find any config that could resolve it.

MaxKalashnyk · 2022-09-19T19:05:10Z

submissions/askuznetsov/html-css-popup/style.scss

+        height: 24px;
+        margin: 24px;
+
+        &:hover {


You can get rid of this hover as you use links inside this list item

MaxKalashnyk · 2022-09-19T19:08:41Z

submissions/askuznetsov/html-css-popup/style.scss

+  }
+}
+
+@media only screen and (max-width: 1200px) {


Please move your media queries to the bottom of this file and store it one place

MaxKalashnyk · 2022-09-19T19:11:14Z

submissions/askuznetsov/html-css-popup/style.scss

+    margin-bottom: 24px;
+
+    &__link {
+      display: block;


Why do you use display: block; here?

MaxKalashnyk · 2022-09-19T19:12:24Z

submissions/askuznetsov/html-css-popup/style.scss

+      transition: all 0.3s ease-out;
+
+      &__image {
+        align-self: center;


Why do you use align-self: center; here?

MaxKalashnyk · 2022-09-19T19:13:00Z

submissions/askuznetsov/html-css-popup/style.scss

+  }
+
+  &__link {
+    display: block;


Why do you use display: block; here?

Just for the last block "Even more from kottans" to make it in next line with all width of popup.

MaxKalashnyk · 2022-09-19T19:14:25Z

submissions/askuznetsov/html-css-popup/style.scss

+#more__checkbox:focus + .more__checkbox__label {
+  border: $border-main;
+  padding: 3px;
+  border-radius: 10px;
+  outline: transparent;
+
+  transition: all 0.3s ease-out;
+}
+
+.more__checkbox__label:focus {
+  border: $border-main;
+  padding: 3px;
+  border-radius: 10px;
+  outline: transparent;
+
+  transition: all 0.3s ease-out;
+}


You can combine these styles

Agree. Combined.

stale · 2022-10-04T21:33:07Z

This issue has been automatically marked as stale because there were no activity during last 14 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

А. Чому так?
Найбільш розповсюджена причина: Студент не реагує на коментарі змінами коду і не задає запитань через брак часу або зміну життєвих пріоритетів. Покинуті піари відволікають менторів. Коли у студента з'явиться час, він/вона зможе перевідкрити той самий піар і продовжити роботу.

Б. Що робити, якщо в піарі нема оновлень, оскільки не зрозуміло, що треба зробити?
Варіант 1. Задати питання в самому PR.
Варіант 2. Задати питання в студентському чаті.

В. А якщо я все зробив(ла) і це ментор не рев'юває мої зміни?

Переконайся, що ти відреагував(ла) на всі коментарі або кодом, або запитаннями, або відповідями. Напиши в PR і в чаті, що чесно вважаєш, що все зроблено і попроси повторне рев'ю. Якщо щось не зрозуміло, задай запитання.
Реагуй на коментарі як менторів, так і інших учасників, включаючи ботів.
Не ігноруй прохання типу * "Let's do some self-checks ..." * "Go through the checklist below..." * "mark fulfilled requirements..." * "if you would silently ignore this recommendation, a mentor may think that you are still working on fixes"
навіть якщо вони написані ботом. Боти помічники і ментори покладаються на те, що прохання і пропозиції бота дотримуються.
Не лінись піти по лінках в коментарях, погуглити термінологію та скористатись Google Translate.
Можливо, у менторів склалися інші пріоритети через роботу, сімейні обставини і т.п. В такому разі, якщо ти зробив(ла) рекомендоване вище, то волай в чаті, що PR позначений stale, наче, все зроблено, а ментори чомусь не реагують - рятуйте!

Г. Хіба недостатньо того, що я додав(ла) коміт із змінами?
Часто буває так, що бачиш новий коміт, ідеш перевіряти, змін багато, доводиться перечитувати весь код. А потім з'ясовується, що одна невеличка зміна "відкладена на потім" чи з'являється ще один коміт і знов треба перечитувати все. Любіть нас, спілкуйтеся з нами - і ми відповімо повною взаємністю.

Традиційна пропозиція: задай питання по вищенаписаному в студентському чаті.

MaxKalashnyk

It seems you pushed irrelevant files to this PR. Please, leave only your files and push changes again

askuznetsov html-css-popup

881ae0c

A-Ostrovnyy added task-PopUp irrelevant-files Files not required for the code review labels Sep 15, 2022

askuznetsov html-css-popup removed imgs

86490cf

removed css. scss stay

5b4710b

fixed errors and warnings in css

6a2410c

MaxKalashnyk suggested changes Sep 19, 2022

View reviewed changes

OleksiyRudenko removed the irrelevant-files Files not required for the code review label Sep 20, 2022

stale bot added 💤 Stale and removed 💤 Stale labels Oct 4, 2022

askuznetsov/HTML-CSS-POPUP/fixes

83b351e

MaxKalashnyk suggested changes Oct 9, 2022

View reviewed changes

olkuznetsov closed this by deleting the head repository Jan 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

askuznetsov html-css-popup #562

askuznetsov html-css-popup #562

olkuznetsov commented Sep 14, 2022 •

edited

Loading

github-actions bot commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

olkuznetsov commented Sep 15, 2022

olkuznetsov commented Sep 15, 2022 •

edited

Loading

olkuznetsov commented Sep 19, 2022

MaxKalashnyk left a comment

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Oct 9, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

MaxKalashnyk Sep 19, 2022

olkuznetsov Oct 9, 2022

stale bot commented Oct 4, 2022

MaxKalashnyk left a comment

askuznetsov html-css-popup #562

askuznetsov html-css-popup #562

Conversation

olkuznetsov commented Sep 14, 2022 • edited Loading

HTML-CSS-Popup

github-actions bot commented Sep 15, 2022

github-actions bot commented Sep 15, 2022

olkuznetsov commented Sep 15, 2022

olkuznetsov commented Sep 15, 2022 • edited Loading

olkuznetsov commented Sep 19, 2022

MaxKalashnyk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Oct 4, 2022

MaxKalashnyk left a comment

Choose a reason for hiding this comment

olkuznetsov commented Sep 14, 2022 •

edited

Loading

olkuznetsov commented Sep 15, 2022 •

edited

Loading