Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-css-popup #49

Merged
merged 5 commits into from
Aug 3, 2022
Merged

html-css-popup #49

merged 5 commits into from
Aug 3, 2022

Conversation

YuliiaDikun
Copy link
Contributor

HTML і CSS практика: Hooli-style Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
See my comments below.

submissions/dikun/html-css-popup/style.css Show resolved Hide resolved
submissions/dikun/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/style.css Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/style.css Show resolved Hide resolved
submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
@YuliiaDikun YuliiaDikun requested a review from A-Ostrovnyy August 2, 2022 18:58
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
One more issue left

submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some BEM elements need their BEM blocks. Also, after pushing your changes click re-request review to notify the reviewer.
image

submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/dikun/html-css-popup/index.html Outdated Show resolved Hide resolved
@YuliiaDikun
Copy link
Contributor Author

Please, look again at my BEM structure. Also, I change the p tag in the a tag on the span tag. I hope, it's okay now. Thank you for your time!

@YuliiaDikun YuliiaDikun requested a review from A-Ostrovnyy August 3, 2022 09:37
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Congratulations

@A-Ostrovnyy A-Ostrovnyy merged commit 1d215ec into kottans:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants