Complete Frogger Game

[deveLabR]

Object-Oriented JavaScript

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[deveLabR]

Self-check done.

[OleksiyRudenko]

@deveLabR more than 1 requirements from those posted/linked by bot are not met.

Please copy/paste the requirements, go through them thoroughly, mark those that are met by the code, ask questions here and/or Students' chat if anything is not clear, fix code accordingly.

[OleksiyRudenko]

Requirements posted/linked by bot address two issues with method update specifically.
Please identify those, copy/paste them as a comment in this PR and fix code accrodingly.

[deveLabR]

If I understood correctly, I need to make corrections according to the following points:

• All numbers like block dimensions, initial locations are defined as constants.
• There are core constants and derived (calculated) constants (e.g. const FIELD_WIDTH = BLOCK_WIDTH * BLOCKS_NUMBER;).
• Separation of Concerns principle is followed (e.g. update method only updates character coordinates and doesn't contain any inline code to check e.g. collisions; calling other methods from update is legitimate).

Did I miss something?

[OleksiyRudenko]

These are relevant.
There is also yet another one addressing the code in the lines my previous comment is associated with.

[deveLabR]

I hope that I understood what is required of me)) now I will try to fix everything

[OleksiyRudenko]

@deveLabR great job!