complete frogger-game

[drewzag]

Frogger Game

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[stale]

discarded

[OleksiyRudenko]

See what the bot asked you to do. It is unlikely that the code will be reviewed until you accomplish self-check and fixes and explicitly confirm that you did this.

I just noticed that you have nearly the full-house of submissions. It would be a shame if closed PR would block your progress.

[drewzag]

My bad, I missed bot's recommendations.

Self-check done!

And I have question about this

Const objects help organizing and structure const data even better, e.g. const PLAYER_CONF = { initialPosition: {x: 1, y: 5}, sprite: '...', ...etc... };

Why is it better? In this case I can accidentally redefine elements in object and don't even get an error

[OleksiyRudenko]

Const objects help organizing and structure const data even better, e.g. const PLAYER_CONF = { initialPosition: {x: 1, y: 5}, sprite: '...', ...etc... };

Why is it better? In this case I can accidentally redefine elements in object and don't even get an error

It is not better in general. It says "Const objects help organizing and structure const data even better"
Think of big configurations that you have in a dedicated file. Now you want to import config from that file.
Your alternatives can be

// 1
import { GAME_SETTINGS } from `./config.js'

// 2
import { FIELD_SETTINGS, PLAYER_SETTINGS, ENEMY_SETTINGS } from `./config.js'

// 3
import {
FIELD_ROW = 5,
FIELD_COLS = 5,
CELL_X_SIZE = 101,
....
ENEMY_MIN_SPEED,
ENEMY_MAX_SPEED,
....
PLAYER_START_COL,
PLAYER_START_ROW,
PLAYER_SIZE_Y,
...
} from `./config.js'

So just pick what works better for the project, readability and code maintenance.

[OleksiyRudenko]

@drewzag perfect job done!

[OleksiyRudenko]

Does this ever happen?
Minor issue.
You may want to fix this in your project repo.

[drewzag]

I've played more than 3 enemies. I'll fix this!
Thanks for your review)