A tiny JS world #443

unabyband · 2022-09-05T12:23:56Z

A tiny JS world

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-05T12:42:44Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- (pre-OOP) exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
- print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
- `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
Object methods like keys, values, entries shouldn't be used when a particular order is required as these do not guarantee any particular order of keys/values. Same refers to for...of and for...in when applied to objects.
Hint: List explicitly the properties used to form an object presentation string.
Men and women belong to the same biological species.
ES6 class or prototype-based OO syntax aren't used.

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

OleksiyRudenko · 2022-09-07T14:38:35Z

@unabyband please double check what the bot asked you to do.

…nd-2022-homeworks into a-tiny-js-world

unabyband · 2022-09-07T18:10:16Z

Double check is done!

OleksiyRudenko

@unabyband good job!
Let's polish it.

OleksiyRudenko · 2022-09-07T18:24:53Z

submissions/unabyband/tiny-js-world/index.js

+ // var test = man;
+ // test.saying = "<h2>Where's the money, Lebowski?</h2>";
+
+ function printInhabitants(inhabitant) {


Does it print inhabitantS?

Oh, sure! Thank you :)

OleksiyRudenko · 2022-09-07T18:26:09Z

submissions/unabyband/tiny-js-world/index.js

+       inhabitant.species,
+       "<strong>" + inhabitant.name + "</strong>",
+       inhabitant.gender,
+       inhabitant.legs,
+       inhabitant.hands,
+       "<em>" + inhabitant.saying + "</em>",
+       inhabitant.friends,


There should be a way to avoid repetition of inhabitant..
How about deconstruction in function parameters definition?

I've been thinking about this way past several days... I definitely want to avoid repetition, but still don't realize how to print different values with different html-styles without repetition....
Okay, I'll try to make it again

I was referrring specifically repetition of inhabitant. fragment.
Check object deconstruction and how you could use it at function parameters definition.

I've fixed it, take a look again, please.

~~Now it is repetition of args. :)~~
~~Check destructuring. And here is exactly your case.~~
Disregard. I was looking into some other code.

OleksiyRudenko · 2022-09-07T19:46:37Z

Check list is still valid. Go through it.
Find what became wrong.

Then make a step back and look into destructuring as commented here

unabyband · 2022-09-07T20:55:44Z

Check list is still valid. Go through it. Find what became wrong.

Then make a step back and look into destructuring as commented here

I should avoid using "for...in" cycle here, shouldn't I?

OleksiyRudenko · 2022-09-07T23:11:38Z

I should avoid using "for...in" cycle here, shouldn't I?

Yes, you are. And there is an explanation as to why, and the reason is valid.

Now, take a step back in your code version and make another try

…nd-2022-homeworks into a-tiny-js-world

unabyband · 2022-09-08T09:48:03Z

I'm not completely sure if it's exactly what I had to do, but please review again.

OleksiyRudenko

@unabyband DRY code still can be customized.
Just needs a bit of creativity.

OleksiyRudenko · 2022-09-08T09:53:06Z

submissions/unabyband/tiny-js-world/index.js

+  const res = [species, name, gender, legs, hands, saying, friends];
+  print (res.join("; "));


Why do you need res (apart of the fact this name violates Universal requirements)?

Also bring back original formatting for name and saying.

Done! Please re-review again

OleksiyRudenko

@unabyband great job!

P.S.

As you have an empty line at the end of file, this ^^ means you have non-Unix newline (most likely you have Windows CRLF).
Check your IDE and git config to ensure newline is Unix-style (LF).

Why this is important? When co-developers have different newline settings this may cause code conflicts and/or mark changes in the files where there are no actually changes beside difference in newline characters.

unabyband · 2022-09-08T10:47:25Z

Thanks a lot! I found it in VSC and switch "EOL" to LF setting.

Adding index.js

8c32e01

unabyband changed the title ~~Adding index.js~~ A tiny JS world Sep 5, 2022

OleksiyRudenko added the task-TJSW label Sep 5, 2022

Update file after prettier

8b5370e

unabyband added 2 commits September 7, 2022 21:02

Edit index.js

b793ce5

Merge branch 'a-tiny-js-world' of https://github.com/unabyband/fronte…

a7c0938

…nd-2022-homeworks into a-tiny-js-world

OleksiyRudenko requested changes Sep 7, 2022

View reviewed changes

unabyband added 2 commits September 7, 2022 22:25

Avoiding repetitions in code

375fb73

adding new line in the end

61f78c7

unabyband requested a review from OleksiyRudenko September 7, 2022 19:28

unabyband added 2 commits September 8, 2022 12:41

Deconstruction parameters of fucntion

16fc8b0

Merge branch 'a-tiny-js-world' of https://github.com/unabyband/fronte…

2533939

…nd-2022-homeworks into a-tiny-js-world

OleksiyRudenko requested changes Sep 8, 2022

View reviewed changes

Edits for array name and output format

d5585ff

unabyband requested a review from OleksiyRudenko September 8, 2022 10:09

New line at the end of the file

21cf128

OleksiyRudenko approved these changes Sep 8, 2022

View reviewed changes

OleksiyRudenko merged commit 89fdf57 into kottans:main Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A tiny JS world #443

A tiny JS world #443

unabyband commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

OleksiyRudenko commented Sep 7, 2022

unabyband commented Sep 7, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 7, 2022

unabyband Sep 7, 2022

OleksiyRudenko Sep 7, 2022

unabyband Sep 7, 2022

OleksiyRudenko Sep 7, 2022 •

edited

Loading

unabyband Sep 7, 2022

OleksiyRudenko Sep 7, 2022 •

edited

Loading

OleksiyRudenko commented Sep 7, 2022

unabyband commented Sep 7, 2022

OleksiyRudenko commented Sep 7, 2022

unabyband commented Sep 8, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 8, 2022

unabyband Sep 8, 2022

OleksiyRudenko left a comment •

edited

Loading

unabyband commented Sep 8, 2022

		const res = [species, name, gender, legs, hands, saying, friends];
		print (res.join("; "));

A tiny JS world #443

A tiny JS world #443

Conversation

unabyband commented Sep 5, 2022

A tiny JS world

github-actions bot commented Sep 5, 2022

A Tiny JS World -- (pre-OOP) exercise check list

Check-list - definition of done

OleksiyRudenko commented Sep 7, 2022

unabyband commented Sep 7, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 7, 2022

Choose a reason for hiding this comment

unabyband Sep 7, 2022

Choose a reason for hiding this comment

OleksiyRudenko Sep 7, 2022

Choose a reason for hiding this comment

unabyband Sep 7, 2022

Choose a reason for hiding this comment

OleksiyRudenko Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

unabyband Sep 7, 2022

Choose a reason for hiding this comment

OleksiyRudenko Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

OleksiyRudenko commented Sep 7, 2022

unabyband commented Sep 7, 2022

OleksiyRudenko commented Sep 7, 2022

unabyband commented Sep 8, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 8, 2022

Choose a reason for hiding this comment

unabyband Sep 8, 2022

Choose a reason for hiding this comment

OleksiyRudenko left a comment • edited Loading

Choose a reason for hiding this comment

unabyband commented Sep 8, 2022

OleksiyRudenko Sep 7, 2022 •

edited

Loading

OleksiyRudenko Sep 7, 2022 •

edited

Loading

OleksiyRudenko left a comment •

edited

Loading