Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task DOM practice (side menu) — done #410

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Conversation

Mifaresss
Copy link
Contributor

DOM API

Link to result | Code base

The code is submitted in a dedicated feature branch. Only code files are submitted.
Please, review.

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes

Universal recommendations:

  • Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
  • Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
  • Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@Mifaresss
Copy link
Contributor Author

I went through common mistakes, everything seems to be ok here. But, unfortunately, I'm generally not sure about the correct execution of the task.

@madmaxWMFU madmaxWMFU self-assigned this Sep 4, 2022
Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Something you can change. Add your data to an array. Then after clicking on the menu item render data.

@Mifaresss
Copy link
Contributor Author

Excuse me, should I just pass the data into an array in a js file? Or does the logic itself need to be redone?

@Mifaresss
Copy link
Contributor Author

I don't know if this comment is necessary, but I've finished working on the bugs)

submissions/Mifaresss/js_dom/script.js Outdated Show resolved Hide resolved
submissions/Mifaresss/js_dom/script.js Outdated Show resolved Hide resolved
submissions/Mifaresss/js_dom/script.js Outdated Show resolved Hide resolved
submissions/Mifaresss/js_dom/script.js Outdated Show resolved Hide resolved
submissions/Mifaresss/js_dom/script.js Outdated Show resolved Hide resolved
submissions/Mifaresss/js_dom/script.js Outdated Show resolved Hide resolved
@Mifaresss
Copy link
Contributor Author

In the styles.css file, I just moved all the code one point to the left

Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I approve of your work. Good luck with future tasks!

@madmaxWMFU madmaxWMFU merged commit d7f1aa1 into kottans:main Sep 20, 2022
@Mifaresss Mifaresss deleted the js_dom branch September 20, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants