Added index.js file to rewiev #385

chernetskyi8704 · 2022-09-01T10:04:36Z

OOP exercise

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-02T17:40:43Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- OOP exercise check list

Relates to A Tiny JS World OOP exercise.

Check-list - definition of done

Minimal requirements to meet:

Optional level up (not required to implement):

Friends list is a list of objects refs rather than names (strings)
Cat-woman class is built employing composition rather than inheritance only

Bonus:

toString magic method; when implemented print(inhabitant) does the job as .toString is called implicitly
this.constructor.name; when used for output then no need to store species property

Helpful resources:

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

chernetskyi8704 · 2022-09-03T11:08:42Z

Has completed self-checks

chernetskyi8704 · 2022-09-16T08:11:42Z

Comment for activity.

OleksiyRudenko

@chernetskyi8704 quite a decent job!
A couple of improvements are still needed.

OleksiyRudenko · 2022-09-20T17:52:05Z

submissions/chernetskyi8704/Tiny JS World/index.js

+
+  displayData() {
+    return ["species", "name", "gender", "saying"]
+      .map((data) => this[data])


data is a generic term. What exactly map works with?

I will take into account in the future, not to use a generic term in situations like that. Thanks a lot.

OleksiyRudenko · 2022-09-20T17:52:35Z

submissions/chernetskyi8704/Tiny JS World/index.js

+  }
+
+  displayData() {
+    return `${super.displayData()}; ${this.hands}; ${this.legs};`;


Please make this (and other similar fragments in subclasses) DRYer with Array#join.
Do not use strings representing propety names. KISS

Thanks a lot. Now really code looks better.

OleksiyRudenko · 2022-09-20T17:53:46Z

submissions/chernetskyi8704/Tiny JS World/index.js

+const man = new Man("Man", "Dimitrij", "male", "Nice to meet you!", 2, 2);
+const woman = new Woman("Woman", "Kate", "male", "Have a good day!", 2, 2);
+const dog = new Dog("Dog", "Molly", "female", "WOOF-WOOF!", 4, 1);
+const cat = new Cat("Cat", "Whiskey", "female", "Meow!", 4, 1);


From the checklist:

No need to specify species at instantiation

There is at least two ways to achieve this. One you already use for a different property. Another one is hinted in the checklist.

Think now i made it correctly.

OleksiyRudenko · 2022-09-20T17:54:07Z

submissions/chernetskyi8704/Tiny JS World/index.js

+// ======== OUTPUT ========
+const allInhabitants = [man, woman, dog, cat];
+
+allInhabitants.map((inhabitan) => {


Check English spelling.

Sorry for that one, it was obvious.

OleksiyRudenko · 2022-09-20T21:38:32Z

I just noticed there are two submissions for TJSW OOP from you.

What tasks exactly implements each of #385 and #575?

Minimal requirements and hence review flow is different for pre-OOP and post-OOP.

chernetskyi8704 · 2022-09-21T09:52:30Z

In #385 I perhaps make more than it requires in 'Building a Tiny JS World (pre-OOP) - practice'. First, it was written like this - chernetskyi8704/a-tiny-JS-world@dcab8f6. But then I asked in the chat if it ok and replied that I needed to be made some changes. My bad that I incorrectly read the requirements.

chernetskyi8704 · 2022-09-21T10:02:44Z

Should I replace this code with the code that in the commit that I send above or just make improvements wich you pointed on?

OleksiyRudenko · 2022-09-21T12:31:50Z

Hold on. I will suggest the approach so that we do not discard what's been done so far in terms of both code and review.

chernetskyi8704 · 2022-09-21T18:33:41Z

Is there something requier to do from me?

…ks with also has made rafactoring.

OleksiyRudenko · 2022-09-23T11:22:22Z

@chernetskyi8704 let's keep this PR for OOP version and #575 for pre-OOP version.

chernetskyi8704 · 2022-09-24T08:51:17Z

@OleksiyRudenko I hope I understood you correctly.

OleksiyRudenko

@chernetskyi8704 nearly there

OleksiyRudenko · 2022-09-26T16:38:54Z

submissions/chernetskyi8704/Tiny JS World/index.js

+    super("Man🤵", Name, Gender, Saying);
+  }
+}
+
+class Woman extends Human {
+  constructor(Name, Gender, Saying) {
+    super("Woman👩", Name, Gender, Saying);


Men and women belong to the same species. I just cannot let heresy pass through :)

Yeah, that was a stupid one.

OleksiyRudenko · 2022-09-26T16:39:43Z

submissions/chernetskyi8704/Tiny JS World/index.js

+    this.Paws = "4";
+    this.Tail = "1";


Not critical here, as we do not really do math operations with paws and tails.
Just wondering, why strings?

Strings because of using string methods.
Should i fix it?

Not necessarily. For example, telephone numbers do not actually make sense as numbers in mathematial sense, as we do not math operations over them. From the other hand we may want to count total number of legs in a herd.

Probably a missing part in your puzzle was that numbers coerce to strings automagically in string context.
Check what 4 + "" results in and why [1, 31, 3, 5, 11].sort() doesn't work as expected. This is an important part of understanding JS internals and peculiarities.

You may skip fixing this. Make sure to take some learnings.

Type conversion it's really a great thing in JS but I'm not thought about this in the border of this task. In the future will ask my self more often 'What about if...'. Thank you so much for the review.

OleksiyRudenko

@chernetskyi8704 great job!

Added index.js file to review

c03c246

chernetskyi8704 force-pushed the tiny-js-world branch from d1411be to c03c246 Compare September 1, 2022 10:08

Has made refactoring my code.

fa92352

A-Ostrovnyy added the task-TJSW-OOP label Sep 2, 2022

chernetskyi8704 mentioned this pull request Sep 5, 2022

Populate world OleksiyRudenko/a-tiny-JS-world#176

Closed

OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022

OleksiyRudenko requested changes Sep 20, 2022

View reviewed changes

OleksiyRudenko self-assigned this Sep 20, 2022

Has corrected grammar mistakes and has specified what exactly map wor…

05fa9b3

…ks with also has made rafactoring.

chernetskyi8704 requested a review from OleksiyRudenko September 23, 2022 08:42

Update PR for OOP version.

5789054

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

Fixed an obvious error.

b529f32

chernetskyi8704 requested a review from OleksiyRudenko September 27, 2022 06:44

OleksiyRudenko approved these changes Sep 27, 2022

View reviewed changes

OleksiyRudenko merged commit 8a31c15 into kottans:main Sep 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added index.js file to rewiev #385

Added index.js file to rewiev #385

chernetskyi8704 commented Sep 1, 2022 •

edited

Loading

github-actions bot commented Sep 2, 2022

chernetskyi8704 commented Sep 3, 2022 •

edited

Loading

chernetskyi8704 commented Sep 16, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 20, 2022

chernetskyi8704 Sep 23, 2022

OleksiyRudenko Sep 20, 2022

chernetskyi8704 Sep 23, 2022

OleksiyRudenko Sep 20, 2022

chernetskyi8704 Sep 23, 2022

OleksiyRudenko Sep 20, 2022

chernetskyi8704 Sep 23, 2022

OleksiyRudenko commented Sep 20, 2022 •

edited

Loading

chernetskyi8704 commented Sep 21, 2022

chernetskyi8704 commented Sep 21, 2022

OleksiyRudenko commented Sep 21, 2022

chernetskyi8704 commented Sep 21, 2022

OleksiyRudenko commented Sep 23, 2022

chernetskyi8704 commented Sep 24, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 26, 2022

chernetskyi8704 Sep 26, 2022

OleksiyRudenko Sep 26, 2022

chernetskyi8704 Sep 26, 2022

OleksiyRudenko Sep 26, 2022

chernetskyi8704 Sep 27, 2022

OleksiyRudenko left a comment

Added index.js file to rewiev #385

Added index.js file to rewiev #385

Conversation

chernetskyi8704 commented Sep 1, 2022 • edited Loading

OOP exercise

github-actions bot commented Sep 2, 2022

A Tiny JS World -- OOP exercise check list

Check-list - definition of done

chernetskyi8704 commented Sep 3, 2022 • edited Loading

chernetskyi8704 commented Sep 16, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko commented Sep 20, 2022 • edited Loading

chernetskyi8704 commented Sep 21, 2022

chernetskyi8704 commented Sep 21, 2022

OleksiyRudenko commented Sep 21, 2022

chernetskyi8704 commented Sep 21, 2022

OleksiyRudenko commented Sep 23, 2022

chernetskyi8704 commented Sep 24, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

chernetskyi8704 commented Sep 1, 2022 •

edited

Loading

chernetskyi8704 commented Sep 3, 2022 •

edited

Loading

OleksiyRudenko commented Sep 20, 2022 •

edited

Loading