Hooli-style Popup #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! Nice formatting, which is pretty easy to read, that's cool. The menu is also looking good Seems there is still some room for UI and accessibility improvements.
Don't hesitate to ask if something is not clear ;) |
I removed the container around the menu icons and the need for centering and extra stroke disappeared. Thanks to this, hover and focus are applied to the icons themselves. Added transparent borders to elements so they don't jump when focusing on them. The "more" button was removed from the grid and the display block was used - it became the entire width of the popup. I put the second part of the pop-up in a separate container. Added a border between the initial content and additional content. Slightly reworked the indents.
|
I made the necessary changes to my files. please check) |
A-Ostrovnyy
requested changes
Jul 31, 2022
kasionio
requested changes
Jul 31, 2022
I have added an unordered list. Removed all alt values. Made an shorthand background. Rounded the values of the alpha channel in rgba. Changed the name of the color to rgb module.
Replaced pixel values with relative ones. Fixed number of display properties in popup-items. Made the page responsive.
A-Ostrovnyy
approved these changes
Aug 1, 2022
|
@A-Ostrovnyy, agree. @natalia-artsiukh, congrats 🎉 |
kasionio
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooli-style Popup
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.