a-tiny-JS-world #36
a-tiny-JS-world #36
Conversation
| gender: "female", | ||
| legs: 2, | ||
| hands: 2, | ||
| saying: cat.saying, |
There was a problem hiding this comment.
Here you are only copying the initial value of the cat.saying. You have to figure out some way to connect those values, so that if you change cat.saying, catWoman.saying changes as well.
| hands: 2, | ||
| saying: cat.saying, | ||
| }; | ||
| const arr = [cat, dog, man, woman, catWoman]; |
There was a problem hiding this comment.
Avoid using data types in the name of the variable. It is a clear indicator that your variable name isn't as obvious as it should be. Let's take this one for example. arr of what? If you use this variable outside this code somewhere, would you be able to understand what data is inside? Let's replace it with something like inhabitants. This gives you and understanding of what data is there and the fact that this is plural suggests that this is an array as well.
| saying: cat.saying, | ||
| }; | ||
| const arr = [cat, dog, man, woman, catWoman]; | ||
| let string = []; |
There was a problem hiding this comment.
Same thing, but even more confusing. A string that is actually and array? Also, you could've printed every inhabitants info separately, it is not against the task, but since you are already doing this, why let? You are not replacing the value anywhere, you are using push. It is allowed to change the value of arrays with functions like push even when the variable is a const.
|
catWoman.prototype = cat.prototype, but I used Object.setPrototypeOf, because Object.create(prototype, descriptors) dont work properly, I dont know why. |
| inhabitantsKeys.reduce((accumulator, prop) => { | ||
| return (accumulator += obj[prop] + "; "); | ||
| }, "") |
There was a problem hiding this comment.
Consider using #Array.map (to map property names into values) and #Array.join (to glue substrings together) here. This will make the code cleaner.
There was a problem hiding this comment.
@Eugene-CG well done!
Check the comment below to improve your code style a bit..
| inhabitantsKeys.map((prop) => { | ||
| return obj[prop]; | ||
| }) |
There was a problem hiding this comment.
This can be reduced to inhabitantsKeys.map(prop => obj[prop]). return statement and surrounding {} are redundant if return is the only statement in arrow function body.
a-tiny-JS-world
Demo
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.