Frogger game by Ivan Chukhalo (the task is a part of #9 'Object Oriented JS' module)

[ivan-chukhalo]

Frogger game

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Frogger Arcade Game -- JS OO exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

• employ ES6 features like const, let etc. (with exclusion of ES6 class syntax)

• the code is very DRY

• Requirements re Constants:

  • all numbers like block dimensions, initial locations are defined as named constants (e.g. const STEP = 101;) as otherwise numbers scattered across code base look cryptic; named constants add semantic meaning and improve readability
  • every number that has a semantic purpose (like those listed above) should be defined as constants; think of how your code reads - the closer to plain English the better
  • there are core constants and derived constants
    (e.g. derived constant const FIELD_WIDTH = BLOCK_WIDTH * BLOCKS_NUMBER;)
  • arrays of constants are also constants
    (e.g. const INITIAL_POSITIONS = [1,2,3,4].map(rowNumber => rowNumber * BLOCK_HEIGHT);)
  • const objects help organizing and structure const data even better
    (e.g. const PLAYER_CONF = { initialPosition: {x: 1, y: 5}, sprite: '...', ...etc... };

• Requirements re OOP:

  • OO is implemented using JS prototype chain object model (not ES6 classes syntax)
  • classes do not refer to any global variables, like global variable player, which is an instance of Player class
    (referring to global constants and globals provided by the gaming platform like Resources is OK);
    Hint: pass Player instance as an argument to every enemy
  • Separation of Concerns principle is followed
    (e.g. update method does only rendering and doesn't contain any unrelated inline code; for example collision check is defined as a dedicated method and only called from inside update)
  • Nice To Have: properties common for some classes are generalized into a base class
    (e.g. there is Character base class, which is extended by Enemy and Player classes)
  • class extension is implemented using Subclass.prototype = Object.create(Superclass.prototype), not Subclass.prototype = new Superclass(params);; Helpful resource

• Most common mistakes

  • Make sure target = condition ? valueWhenConditionTrue : valueWhenConditionFalse is used instead of condition ? target = valueWhenConditionTrue : target = valueWhenConditionFalse; Conditional (ternary) operator

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[ivan-chukhalo]

@OleksiyRudenko

I've run through the check-list, made few changes in my work. Seems it does not have common mistakes anymore.
Please, review.

[OleksiyRudenko]

@ivan-chukhalo great job!

[OleksiyRudenko]

There must be some formula to calculate pixel Y from row number...
Good news is that computers are made to do calculations for us. We need to benefit from this fact to make our lives better.

[OleksiyRudenko]

@ivan-chukhalo an improtant fix to do.

[OleksiyRudenko]

* [ ] classes do not refer to any global variables, like global variable `player`, which is an instance of `Player` class

  (referring to global constants and globals provided by the gaming platform like `Resources` is OK);
  Hint: pass `Player` instance as an argument to every enemy

[ivan-chukhalo]

Thank you for comments. I've made requested changes.

[OleksiyRudenko]

@ivan-chukhalo nearly there

[OleksiyRudenko]

player is still a global variable.
The requirements provide a hint on how to resolve the problem.

[ivan-chukhalo]

@OleksiyRudenko, excuse me.

It seems like I've missed this row or I got rid of global variables dependencies in the project, then made some extra changes in the code and added new dependency without noticing it)

Fixed issue. Review, please.

[OleksiyRudenko]

This line of code seems to remain unchanged. player is a global variable.
The requirements provide hint on how to resolve the issue.

[ivan-chukhalo]

@OleksiyRudenko

User Acceptance Tests have been conducted and no bugs have been found.

[OleksiyRudenko]

Note that UAT doesn't make issues pointed out by a mentor obsolete.

[ivan-chukhalo]

@OleksiyRudenko

Added an income parameter (refered to another class entity) for a class' function and forgot to rewrite function's body in previous commit😱😩. Excuse me.

I fixed the problem (as I consider), ran through code and made few extra changes to fix things which I thought could be mistakes. Basically, I did an extra self check.

[OleksiyRudenko]

@ivan-chukhalo great job!

[OleksiyRudenko]

elem is a bad naming