The 5 #333

olehmaksymych · 2022-08-28T17:40:48Z

[HTML & CSS Practice]

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-08-29T06:02:26Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

This PR contains irrelevant files.

You can see this under Files changed tab (you will find a couple of helpful tabs right under the PR title).

Most likely, you added all files from your project, not only required and sufficient code review as instructed in section B123 of submission instructions. Also read an important note therein.

Why we want only few files?

It helps code reviewers to focus on code you authored and have the workspace uncluttered with irrelevant images and transpiled files.
This keeps homeworks repository small.
For example, images add to the weight of the repo and will affect download/upload time for mentors and other students. We all care about others' time.

Please fix this issue by removing irrelevant files and add a comment stating that you did this.

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

github-actions · 2022-08-29T06:02:34Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes.

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

…ks into html_popup

…homeworks into html_popup

olehmaksymych · 2022-09-07T06:03:03Z

Thank you, will wait for the approving request.

HannaSyn

Nice work, please, add ability to navigate through all header and menu with keyboard.
Check my comment below

HannaSyn · 2022-09-08T09:34:56Z

submissions/olehmaksymych/html_popup/index.html

+        <div class="header_item">
+          <input type="checkbox" id="popup_box" class="icon_for_thecheckbox" />
+          <label for="popup_box" class="popup_label">
+            <img src="icons/popup-icons/popup-button.png" alt="popup-icon" id="popup_icon"/>


For icons it's better set an empty alt attribute, read more here

HannaSyn · 2022-09-08T09:36:27Z

submissions/olehmaksymych/html_popup/index.html

+      <nav class="header_menu">
+        <a class="navbar" href="#"> Home </a>
+        <a class="navbar" href="#">Bgood</a>
+        <a class="navbar" href="#">RobinGood</a>
+      </nav>


this should be a list ul>li>a

HannaSyn · 2022-09-08T09:37:13Z

submissions/olehmaksymych/html_popup/index.html

+  <body>
+    <header class="header">
+
+      <div class="header_checkbox">


nav should start here and wrap menu icon too, also it is a list element li

HannaSyn · 2022-09-08T09:38:46Z

submissions/olehmaksymych/html_popup/styl.css

+} 
+
+ .header_item {
+  /* the style for the header list items */


Please, remove all unnecessary comments in this file

HannaSyn · 2022-09-08T09:39:24Z

submissions/olehmaksymych/html_popup/styl.css

+.header_menu  a.navbar.active,
+.header_menu a.navbar:hover{


Please, avoid styling by tags link, use classnames instead

submissions/olehmaksymych/html_popup/styll.css

olehmaksymych · 2022-09-15T10:46:16Z

I have made the changes. Check it on your side, please.

HannaSyn · 2022-09-28T09:51:43Z

There are no changes in files, please check

stale · 2022-10-12T12:17:42Z

This issue has been automatically marked as stale because there were no activity during last 14 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

А. Чому так?
Найбільш розповсюджена причина: Студент не реагує на коментарі змінами коду і не задає запитань через брак часу або зміну життєвих пріоритетів. Покинуті піари відволікають менторів. Коли у студента з'явиться час, він/вона зможе перевідкрити той самий піар і продовжити роботу.

Б. Що робити, якщо в піарі нема оновлень, оскільки не зрозуміло, що треба зробити?
Варіант 1. Задати питання в самому PR.
Варіант 2. Задати питання в студентському чаті.

В. А якщо я все зробив(ла) і це ментор не рев'юває мої зміни?

Переконайся, що ти відреагував(ла) на всі коментарі або кодом, або запитаннями, або відповідями. Напиши в PR і в чаті, що чесно вважаєш, що все зроблено і попроси повторне рев'ю. Якщо щось не зрозуміло, задай запитання.
Реагуй на коментарі як менторів, так і інших учасників, включаючи ботів.
Не ігноруй прохання типу * "Let's do some self-checks ..." * "Go through the checklist below..." * "mark fulfilled requirements..." * "if you would silently ignore this recommendation, a mentor may think that you are still working on fixes"
навіть якщо вони написані ботом. Боти помічники і ментори покладаються на те, що прохання і пропозиції бота дотримуються.
Не лінись піти по лінках в коментарях, погуглити термінологію та скористатись Google Translate.
Можливо, у менторів склалися інші пріоритети через роботу, сімейні обставини і т.п. В такому разі, якщо ти зробив(ла) рекомендоване вище, то волай в чаті, що PR позначений stale, наче, все зроблено, а ментори чомусь не реагують - рятуйте!

Г. Хіба недостатньо того, що я додав(ла) коміт із змінами?
Часто буває так, що бачиш новий коміт, ідеш перевіряти, змін багато, доводиться перечитувати весь код. А потім з'ясовується, що одна невеличка зміна "відкладена на потім" чи з'являється ще один коміт і знов треба перечитувати все. Любіть нас, спілкуйтеся з нами - і ми відповімо повною взаємністю.

Традиційна пропозиція: задай питання по вищенаписаному в студентському чаті.

olehmaksymych added 2 commits August 28, 2022 20:22

The 5

b010e7f

The changes in the code are applied.

22a3245

A-Ostrovnyy added task-PopUp irrelevant-files Files not required for the code review labels Aug 29, 2022

olehmaksymych added 2 commits August 31, 2022 18:26

I cHANGED THE CODE SUCCESSFULLY

3f0394e

The one more time

cbc643b

A-Ostrovnyy removed the irrelevant-files Files not required for the code review label Aug 31, 2022

olehmaksymych and others added 6 commits August 31, 2022 22:41

The last one change for sure.

4922db7

Merge branch 'kottans:main' into html_popup

0db5275

the last зміни

4c18db9

Rename the folder correctly

5d16a2d

Merge branch 'main' of github.com:olehmaksymych/frontend-2022-homewor…

c15838f

…ks into html_popup

cMerge branch 'html_popup' of github.com:olehmaksymych/frontend-2022-…

4d05eba

…homeworks into html_popup

olehmaksymych mentioned this pull request Sep 5, 2022

your-github-username: Import tasks from another homeworks repo #401

Closed

HannaSyn self-assigned this Sep 8, 2022

HannaSyn requested changes Sep 8, 2022

View reviewed changes

olehmaksymych requested a review from HannaSyn September 15, 2022 10:45

stale bot added the 💤 Stale label Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The 5 #333

The 5 #333

olehmaksymych commented Aug 28, 2022 •

edited

Loading

github-actions bot commented Aug 29, 2022

github-actions bot commented Aug 29, 2022

olehmaksymych commented Sep 7, 2022

HannaSyn left a comment

HannaSyn Sep 8, 2022

HannaSyn Sep 8, 2022

HannaSyn Sep 8, 2022

HannaSyn Sep 8, 2022

HannaSyn Sep 8, 2022

olehmaksymych commented Sep 15, 2022

HannaSyn commented Sep 28, 2022

stale bot commented Oct 12, 2022

		.header_menu a.navbar.active,
		.header_menu a.navbar:hover{

The 5 #333

Are you sure you want to change the base?

The 5 #333

Conversation

olehmaksymych commented Aug 28, 2022 • edited Loading

[HTML & CSS Practice]

github-actions bot commented Aug 29, 2022

github-actions bot commented Aug 29, 2022

olehmaksymych commented Sep 7, 2022

HannaSyn left a comment

Choose a reason for hiding this comment

HannaSyn Sep 8, 2022

Choose a reason for hiding this comment

HannaSyn Sep 8, 2022

Choose a reason for hiding this comment

HannaSyn Sep 8, 2022

Choose a reason for hiding this comment

HannaSyn Sep 8, 2022

Choose a reason for hiding this comment

HannaSyn Sep 8, 2022

Choose a reason for hiding this comment

olehmaksymych commented Sep 15, 2022

HannaSyn commented Sep 28, 2022

stale bot commented Oct 12, 2022

olehmaksymych commented Aug 28, 2022 •

edited

Loading