added popup #278

Alissy27 · 2022-08-23T16:14:32Z

added popup local 2 files: index.html and style.css

github-actions · 2022-08-23T17:00:31Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes.

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

A-Ostrovnyy

Please provide a link with a demo to validate your work properly.
Also, edit your first message according to the template.

A-Ostrovnyy · 2022-08-27T09:54:02Z

submissions/Alissy27/popup/index.html

+            <li class="nav__li"><a href="#">Mail</a></li>
+            <li class="nav__li"><a href="#">Images</a></li>
+            <li class="nav__li"><a href="#">
+                <img class="nav__img" src="https://alissy27.github.io/Test/img/bell.png" alt="bell"></a>


Read how and when to populate alt attribute value Как правильно написать alt-текст

deleted alts from icons

A-Ostrovnyy · 2022-08-27T09:55:29Z

submissions/Alissy27/popup/style.css

+    margin-left: 15px;
+}
+
+.nav__popup label{


Avoid styling by HTML tags except if you add base styles. Reason Also, avoid too specific CSS selectors. Read more about that

added class to label, changed css

Alissy27 · 2022-08-28T12:40:44Z

Demo |
Code base

github-actions · 2022-08-28T16:47:52Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

This PR intro message is not completed.

Please edit it following the instructions therein and add a comment stating that you did this.

How to start editing the top comment:

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

A-Ostrovnyy

Good work!
Please add links to your first message

A-Ostrovnyy · 2022-08-28T16:51:47Z

submissions/Alissy27/popup/index.html

+                <input type="checkbox" id="popup__checkbox">
+                <label for="popup__checkbox" class="label__checkbox">


Avoid shifting sibling elements on hover or focus state. Watch video

A-Ostrovnyy · 2022-08-28T16:52:15Z

submissions/Alissy27/popup/index.html

+<body>
+
+<header class="header header__flex">
+    <img class="logo" src="https://alissy27.github.io/Test/puma.jfif" alt="puma">


A logo should be a link that leads to the home page.

A-Ostrovnyy · 2022-08-28T16:53:38Z

submissions/Alissy27/popup/index.html

+            <li class="nav__li"><a href="#">Mail</a></li>
+            <li class="nav__li"><a href="#">Images</a></li>
+            <li class="nav__li"><a href="#">
+                <img class="nav__img" src="https://alissy27.github.io/Test/img/bell.png" alt="bell"></a>


Add cursor: pointer to all interactive elements.

A-Ostrovnyy · 2022-08-28T16:56:49Z

submissions/Alissy27/popup/index.html

+                                <a href="#">
+                                    <img class="popup__img" src="https://alissy27.github.io/Test/img/apps.png" alt="apps">
+                                    <p>Apps</p>
+                                </a>


Fix styles on focus state.

stale · 2022-09-19T20:00:48Z

This issue has been automatically marked as stale because there were no activity during last 14 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

А. Чому так?
Найбільш розповсюджена причина: Студент не реагує на коментарі змінами коду і не задає запитань через брак часу або зміну життєвих пріоритетів. Покинуті піари відволікають менторів. Коли у студента з'явиться час, він/вона зможе перевідкрити той самий піар і продовжити роботу.

Б. Що робити, якщо в піарі нема оновлень, оскільки не зрозуміло, що треба зробити?
Варіант 1. Задати питання в самому PR.
Варіант 2. Задати питання в студентському чаті.

В. А якщо я все зробив(ла) і це ментор не рев'юває мої зміни?

Переконайся, що ти відреагував(ла) на всі коментарі або кодом, або запитаннями, або відповідями. Напиши в PR і в чаті, що чесно вважаєш, що все зроблено і попроси повторне рев'ю. Якщо щось не зрозуміло, задай запитання.
Реагуй на коментарі як менторів, так і інших учасників, включаючи ботів.
Не ігноруй прохання типу * "Let's do some self-checks ..." * "Go through the checklist below..." * "mark fulfilled requirements..." * "if you would silently ignore this recommendation, a mentor may think that you are still working on fixes"
навіть якщо вони написані ботом. Боти помічники і ментори покладаються на те, що прохання і пропозиції бота дотримуються.
Не лінись піти по лінках в коментарях, погуглити термінологію та скористатись Google Translate.
Можливо, у менторів склалися інші пріоритети через роботу, сімейні обставини і т.п. В такому разі, якщо ти зробив(ла) рекомендоване вище, то волай в чаті, що PR позначений stale, наче, все зроблено, а ментори чомусь не реагують - рятуйте!

Г. Хіба недостатньо того, що я додав(ла) коміт із змінами?
Часто буває так, що бачиш новий коміт, ідеш перевіряти, змін багато, доводиться перечитувати весь код. А потім з'ясовується, що одна невеличка зміна "відкладена на потім" чи з'являється ще один коміт і знов треба перечитувати все. Любіть нас, спілкуйтеся з нами - і ми відповімо повною взаємністю.

Традиційна пропозиція: задай питання по вищенаписаному в студентському чаті.

added popup local

0af679e

added popup local 2 files: index.html and style.css

OleksiyRudenko added the task-PopUp label Aug 23, 2022

changed files

4ac1d5d

A-Ostrovnyy self-assigned this Aug 27, 2022

A-Ostrovnyy requested changes Aug 27, 2022

View reviewed changes

A-Ostrovnyy added the bad-pr-intro label Aug 28, 2022

A-Ostrovnyy requested changes Aug 28, 2022

View reviewed changes

OleksiyRudenko removed the bad-pr-intro label Sep 5, 2022

stale bot added the 💤 Stale label Sep 19, 2022

stale bot closed this Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added popup #278

added popup #278

Alissy27 commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022

A-Ostrovnyy left a comment •

edited

Loading

A-Ostrovnyy Aug 27, 2022

Alissy27 Aug 28, 2022

A-Ostrovnyy Aug 27, 2022

Alissy27 Aug 28, 2022

Alissy27 commented Aug 28, 2022

github-actions bot commented Aug 28, 2022

A-Ostrovnyy left a comment

A-Ostrovnyy Aug 28, 2022

A-Ostrovnyy Aug 28, 2022

A-Ostrovnyy Aug 28, 2022

A-Ostrovnyy Aug 28, 2022

stale bot commented Sep 19, 2022

		<input type="checkbox" id="popup__checkbox">
		<label for="popup__checkbox" class="label__checkbox">

added popup #278

added popup #278

Conversation

Alissy27 commented Aug 23, 2022 • edited Loading

github-actions bot commented Aug 23, 2022

A-Ostrovnyy left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alissy27 commented Aug 28, 2022

github-actions bot commented Aug 28, 2022

A-Ostrovnyy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Sep 19, 2022

Alissy27 commented Aug 23, 2022 •

edited

Loading

A-Ostrovnyy left a comment •

edited

Loading