Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html css popup task #169

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Html css popup task #169

merged 4 commits into from
Aug 22, 2022

Conversation

mimoauto
Copy link
Contributor

HTML CSS PopUp

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations with your PR! 😎😎😎

Please, be sure you haven't followed common mistakes.

Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒

@A-Ostrovnyy A-Ostrovnyy self-assigned this Aug 22, 2022
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@mimoauto mimoauto requested a review from A-Ostrovnyy August 22, 2022 11:15
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add styles on focus state to the more button.

@mimoauto mimoauto requested a review from A-Ostrovnyy August 22, 2022 16:28
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@A-Ostrovnyy A-Ostrovnyy merged commit bb03a5e into kottans:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants