Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file for hoolie-popup task #127

Merged
merged 8 commits into from
Aug 24, 2022

Conversation

maksimsergeev97
Copy link
Contributor

HTML і CSS практика: Hooli-style Popup

Demo | Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations with your PR! 😎😎😎

Please, be sure you haven't followed common mistakes.

Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒

@maksimsergeev97
Copy link
Contributor Author

Hey!
my code has been validated.
I took into account all the tips from common mistakes when writing code

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
See my comments below.

@A-Ostrovnyy A-Ostrovnyy self-assigned this Aug 18, 2022
@maksimsergeev97
Copy link
Contributor Author

Hey! Thanks for the review! Code fixed!

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good prgress!

@maksimsergeev97
Copy link
Contributor Author

Hey! Thanks for the help ! Fixed. I ask for a review, again :)

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit 0e3ffc0 into kottans:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants