Skip to content

Fixed a binary compatibility error when using a higher version of KotlinModule #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fixed a binary compatibility error when using a higher version of KotlinModule #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ktorm-jackson/src/main/kotlin/org/ktorm/jackson/JsonSqlType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package org.ktorm.jackson
import com.fasterxml.jackson.databind.JavaType
import com.fasterxml.jackson.databind.ObjectMapper
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
import com.fasterxml.jackson.module.kotlin.KotlinModule
import com.fasterxml.jackson.module.kotlin.kotlinModule
import org.ktorm.schema.*
import java.lang.reflect.InvocationTargetException
import java.sql.PreparedStatement
Expand All @@ -31,7 +31,7 @@ import java.sql.Types
*/
public val sharedObjectMapper: ObjectMapper = ObjectMapper()
.registerModule(KtormModule())
.registerModule(KotlinModule())
.registerModule(kotlinModule())
Copy link

@arnodenuijl arnodenuijl Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the following?
.registerModule(KotlinModule.Builder().build())

Copy link
Contributor Author

@k163377 k163377 Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlinModule() is a short hand that does the same.

https://github.com/FasterXML/jackson-module-kotlin/blob/2.17/src/main/kotlin/com/fasterxml/jackson/module/kotlin/Extensions.kt#L24-L28

Copy link

@aukolov aukolov Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnodenuijl , could you check the answer from @k163377 and review again?

Copy link

@arnodenuijl arnodenuijl Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Sadly it's not mine to merge. I just commented because I had the same issue and didn't understand the fix. But it's not my repo and I don't have any rights on it.

.registerModule(JavaTimeModule())

/**
Expand Down