Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For update #247

Merged
merged 15 commits into from
Feb 28, 2021
Merged

For update #247

merged 15 commits into from
Feb 28, 2021

Conversation

efenderbosch
Copy link

Implements per-dialect FOR UPDATE options. PostgreSQL and MySQL are fully implemented. Oracle and MS SqlServer might have additional options that I'm not aware of. Initial discussion happened in PR #238.

vincentlauvlwj and others added 15 commits January 30, 2021 00:54
@vincentlauvlwj
fix typo
2870ffb
dialect specific for update options for mysql and postgres
343170d
cleaned up UnsupportedMySqlVersionException
92a0f88
renamed visitForUpdate -> writeForUpdate to match writePagination
fc670a2
renamed ForUpdateExpression to ForUpdateOption
dfd9d58
throw DialectFeatureNotSupportedException instead of no-op when diale…
58a1d8f 
…ct does not support the ForUpdateOption
basic for update options for Oracle and SqlServer; formatting
5c5aa90
minor typo in comment
893803a
better comment on ForUpdateOption
db764ad
implemented Postgres for update as described in postgresql.org docs
ed418ac
minor clean up
366399f
fix typo in comment and update to explain new forUpdate behavior
fc5368e
use database.productVersion instead of getting a new connection for m…
0f17096 
…etaData
made ForUpdateOption non-nullable; update testcontainers and detekt d…
368b0db 
…ependencies
merge upstread master
eff9ef1
@vincentlauvlwj vincentlauvlwj changed the base branch from master to v3.4.x February 28, 2021 13:30
vincentlauvlwj
vincentlauvlwj approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@vincentlauvlwj vincentlauvlwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, will release in next version.

@vincentlauvlwj vincentlauvlwj merged commit 93ab10d into kotlin-orm:v3.4.x Feb 28, 2021
@vincentlauvlwj vincentlauvlwj mentioned this pull request Feb 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentlauvlwj vincentlauvlwj vincentlauvlwj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efenderbosch @vincentlauvlwj