fix infinite loop on useeffect #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark scope as private to avoid name clash use reactivestreams / coroutine snippet for KMongo support
jeffdgr8
reviewed
Oct 17, 2021
| val (shoppingList, setShoppingList) = useState(emptyList<ShoppingListItem>()) | ||
|
|
||
| useEffect { | ||
| useEffect(arrayOf(emptyList<ShoppingListItem>().asDynamic())) { |
There was a problem hiding this comment.
useEffectOnce fixes this too, a little simpler.
SebastianAigner
force-pushed
the
final
branch
from
5fe4c62 to
285d113
Compare
Member
|
Thanks so much! We’ve completely overhauled this tutorial to be compatible with the latest version of the wrappers, which also fixes this! I appreciate y’all pointing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a well known problem in the React community but not easily noticeable.
useEffectupdates the state and the state callsuseEffect. In this case, the call ofuseEffectfetches the network which can be detected in the network tab of any browser's developer tools.I simply put passed an empty list as dependencies since we want the
useEffectto be called only once (when page loads). Kotlin'suseEffecthas a deprecated overload, so I used an array ofdynamics to force the compiler chose the up-to-date overload.