Skip to content

Conversation

SourangshuGhosh
Copy link
Contributor

Respected Sir,
Want to merge this request on the issue #140 Add 404.html file.

Copy link
Member

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @SourangshuGhosh Thanks for the PR. I highly appreciate the same.

There is one major change that we require in this PR, inclusion of KOSS website header and footer on the 404 page. You can look at other HTML pages on how that can be done and revert back if you face any issues.

There are two other minor change requests that you can find in the comments.

<div class="container">
<img class="ops" src="./assets/images/404.svg" />
<br />
<h3>The Page you are looking for might have been removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a slight grammatical and spelling error here; shouldn't it be,

The page you are looking for might have been removed, had its name changed, or its temporarily unavailable!

@@ -0,0 +1,66 @@
@charset "UTF-8";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a screenshot of how the page looks? That would really make reviewing easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants