Skip to content

Conversation

sudo-rgorai
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented May 15, 2020

Hello @sudo-rgorai! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-16 16:45:45 UTC

@yashrsharma44
Copy link
Member

Hey @sudo-rgorai ! Thanks for the PR. Meanwhile there are some PEP8 issues that you might want to fix before this PR is merged, so I would suggest you installing pycodestyle which helps you check the PEP8 changes using a cli

@sudo-rgorai
Copy link
Contributor Author

Hey @yashrsharma44. Thanks for the advice. I've fixed PEP8 issues. I just need to make some more changes in designations.

@sudo-rgorai
Copy link
Contributor Author

Hey @yashrsharma44. Thanks for the advice. I've fixed PEP8 issues. I just need to make some more changes in designations.

Done. Please check the PR.

@mukul-mehta
Copy link
Member

I've tested the PR locally, everything seems to be working.

We can merge once reviews are complete.
@yashrsharma44 @americast @xypnox please review

@xypnox xypnox merged commit eb9e30d into kossiitkgp:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants