Merge pull request Expensify#24515 from allroundexperts/fix-15289-fol…

…lowup fix: popover without overlay changes
kosmydel · Aug 22, 2023 · 6609308 · 6609308
2 parents d38c06c + 9ba7700
commit 6609308
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/components/PopoverProvider/index.js b/src/components/PopoverProvider/index.js
@@ -48,7 +48,10 @@ function PopoverContextProvider(props) {
     }, [closePopover]);
 
     React.useEffect(() => {
-        const listener = () => {
+        const listener = (e) => {
+            if (!activePopoverRef.current || !activePopoverRef.current.ref || !activePopoverRef.current.ref.current || activePopoverRef.current.ref.current.contains(e.target)) {
+                return;
+            }
             closePopover();
         };
         document.addEventListener('contextmenu', listener);

diff --git a/src/components/PopoverWithoutOverlay/index.js b/src/components/PopoverWithoutOverlay/index.js
@@ -35,6 +35,7 @@ function Popover(props) {
         } else {
             props.onModalHide();
             close(props.anchorRef);
+            Modal.onModalDidClose();
         }
         Modal.willAlertModalBecomeVisible(props.isVisible);
         Modal.setCloseModal(props.isVisible ? () => props.onClose(props.anchorRef) : null);