Repository navigation
core: fail $well_formed when subject_type is empty or only whitespace - #121
Merged
Merged
Conversation
Rows and the descriptions of the checks ergo adds name the subject by its subject_type, so "" or " " gave sentences that name nothing, like "at least 1 matching subject(s) required". It's now reported like a subject_type of the wrong type. Changes the report: a requirement with an empty or whitespace-only subject_type fails $well_formed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jbpros
added
enhancement
# Conflicts: # ergo_test.rego
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows and the descriptions of the checks ergo adds name the subject by its
subject_type, so an empty one gives sentences that name nothing. On main,"subject_type": " "givesThe in-scope count is at least 1andThe is in scope.A
subject_typethat's empty or only whitespace now fails$well_formed, reported like asubject_typeof the wrong type:{ "name": "subject_type", "value": "" }"a b"and any other string with something besides whitespace in it is still fine.If #113 moves subjects into their own section, as Tooky suggested, an empty subject name there should fail the same way. That's noted on #113.
Changes the report: a requirement with an empty or whitespace-only
subject_typefails$well_formed.Checks
.github/wasm-js.cjs, plus regal, full coverage and the comment check.subject_type.🤖 Generated with Claude Code