Skip to content

No colour: [+] PASSED and [-] FAILED are indistinguishable in a CI log #98

Description

@korya

Problem

The output contains no ANSI colour at all. There is no IsTerminal/isatty check, no NO_COLOR handling, and no escape sequences anywhere in the source.

$ http-assert --assert-ok .../500 2>&1 | grep -c $'\033'
0

Why it matters

The entire point of the output is a verdict, and [+] PASSED / [-] FAILED are distinguished only by one character. Scrolling a CI log, a failure looks exactly like a success. This is the cheapest possible legibility win the tool has available: green on [+], red on [-], and arguably red on the - assertion: … lines.

The sigil vocabulary is already good and the README documents it fully — colour would reinforce it, not replace it.

Suggested fix

Colour [+] green and [-] / Error: red when stderr is a TTY. Honour NO_COLOR and add --color=auto|always|never, defaulting to auto, so CI logs and pipes stay clean.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions