Skip to content

Opening existing note shows error, slow #162

@ylansegal

Description

@ylansegal

Thank you for working on this extension. I find it incredibly useful on my day-to-day note taking. Thanks for sharing!

Describe the bug
Opening existing note shows an error, and is slow (compared to opening an existing note), when:

  • Configuring to use "vscodeMarkdownNotes.newNoteDirectory": "WORKSPACE_ROOT",
  • Notes reside in a sub-directory

To Reproduce

  • Configure extention to use "vscodeMarkdownNotes.newNoteDirectory": "WORKSPACE_ROOT",
  • Create a note test.md, with the following contents
[[my_dir/new_note]]
[[my_dir/existing_note]]
  • Make a subdirectory my_dir
  • Create a note in my_dir/existing_note.md
  • Use the "Go To Definition" functionality on each link in test.md.

Expected behavior

  • No error is shown when opening an existing note
  • Opening an existing note is not slow. Note: On the video, the sub directory doesn't have many files, but the slowness is particularly noticeable in other directories with files in the hundreds.

Screenshots

demo.mov

Versions

  • macOS 11.6.7
  • VS Code Version:
$ code -v
1.68.1
30d9c6cd9483b2cc586687151bcbcd635f373630
x64
  • Extension Version: v0.0.24

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions