Skip to content

Support TLS session ticket resumption #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Conversation

cyang1
Copy link
Contributor

@cyang1 cyang1 commented Mar 11, 2020

Initial draft of session ticket resumption support.

There's a bit that probably needs to be fleshed out here:

  • Like ALPN, the relevant APIs for session ticket resumption are also only available on 10.13 and above. I'm currently handling this in a similar way to ALPN by introducing a new feature, but I'm not sure this is a good idea/scalable way to expose features only available on newer versions.
  • The public API for this is a bit convoluted, pub fn enable_session_tickets(&mut self, address: &[u8]) -> &mut Self. This is because we need a parameter to pass to set_peer_id, and AFAICT, a valid parameter isn't available to us at this abstraction level, without the user passing it in manually.

Fixes #94.

@cyang1
Copy link
Contributor Author

cyang1 commented Mar 12, 2020

On second thought, I suspect we don't need the peer address throughout, as TLS session ticket resumption is meant to be stateless and work across different servers as long as they share the same key.

@kornelski kornelski merged commit c334cc2 into kornelski:master Mar 13, 2020
@kornelski
Copy link
Owner

That looks good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to support TLS session ticket resumption
2 participants