Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

support for SHA512 #617

Closed
benkuly opened this issue May 2, 2022 · 3 comments · Fixed by #627
Closed

support for SHA512 #617

benkuly opened this issue May 2, 2022 · 3 comments · Fixed by #627
Labels
enhancement New feature or request

Comments

@benkuly
Copy link

benkuly commented May 2, 2022

It would be really cool to have support for SHA512 in krypto.
I also think HMAC.hmac(...) and PBKDF2.pbkdf2(...) should be public to let the user decide, which Hasher they want to use.

I'm willing to sponsor this :)
@soywiz soywiz added the enhancement New feature or request label May 2, 2022
@soywiz
Copy link
Contributor

soywiz commented May 2, 2022

Can I ask what's your use-case for SHA512?

@benkuly
Copy link
Author

benkuly commented May 3, 2022

For Pbkdf2Sha512, which is defined by Matrix Client-Server Spec.

soywiz added a commit that referenced this issue May 6, 2022
@soywiz
WIP implement SHA512
5d51b9c 
Fixes #617
@soywiz soywiz mentioned this issue May 6, 2022
Merged
@benkuly
Copy link
Author

benkuly commented May 6, 2022

Awesome! That was fast. Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement SHA512 korlibs-archive/korge-next
2 participants
@soywiz @benkuly