libarchive based android luajit launcher #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
benoit-pierre
force-pushed
the
pr/libarchive_based_android-luajit-launcher
branch
from
3a6369e to
2b4c079
Compare
Frenzie
approved these changes
May 16, 2025
pazos
approved these changes
May 16, 2025
benoit-pierre
force-pushed
the
pr/libarchive_based_android-luajit-launcher
branch
from
2b4c079 to
a66f0da
Compare
|
Oops, I didn't realize #2095 would conflict or I'd have merged this one first. |
benoit-pierre
force-pushed
the
pr/libarchive_based_android-luajit-launcher
branch
from
a66f0da to
146642c
Compare
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
May 26, 2025
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
May 26, 2025
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
May 27, 2025
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libarchive supporting the 7z format, we can use it for decompressing assets on Android, instead of maintaining a different (more complicated and less maintainable) implementation.
This move out building all JNI libraries out of gradle.
Code size reduction: -14.2 KB on ARM, -27.5 KB on ARM64.
We also gain support for ZSTD during development, for example testing the ARM build on my old Nexus 7:
-m0=lzma2 -mx=9-m0=flzma2 -mx=9-m0=zstd -mhc=off -mx=19-m0=zstd -mhc=off -mx=16This change is