Skip to content

Add Boox Go 7 support #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2025
Merged

Add Boox Go 7 support #556

merged 11 commits into from
May 21, 2025

Conversation

jadehawk
Copy link
Contributor

@jadehawk jadehawk commented May 21, 2025

Add ONYX_GO7 device entry and detection

Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito

Drivers that Work:
Onyx ADB (Lights)
Onyx SDK (Lights)
Onyx/Qualcomm (E-ink)

test.log


This change is Reviewable

jadehawk added 4 commits May 20, 2025 20:03
Add ONYX_GO7 device entry and detection

Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito
Add ONYX_GO7 device entry and detection

Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito
Add ONYX_GO7 device entry and detection

Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito
Add ONYX_GO7 device entry and detection

Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito
@jadehawk
Copy link
Contributor Author

Fail Syntax Check

@jadehawk jadehawk closed this May 21, 2025
Add ONYX_GO7 device entry and detection

Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito

Drivers that Work:
Onyx ADB (Lights)
Onyx SDK (Lights)
Onyx/Qualcomm (E-ink)
@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

Please use this same PR. Do not open an additional PR.

@hugleo hugleo reopened this May 21, 2025
@jadehawk
Copy link
Contributor Author

Please use this same PR. Do not open an additional PR.

Copy. Still learning. Apologies.

@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

The GO6 device was already sorted in the correct order.

@jadehawk
Copy link
Contributor Author

jadehawk commented May 21, 2025

The GO6 device was already sorted in the correct order.

Assumed list was in alphabetical order. My mistake then.

Should I return it order:

    ONYX_GO_103,
    ONYX_GO6,
    ONLY_GO7,       <<<<< Adding the new line here instead?
    ONYX_GO_COLOR7,
    
    
    
    =================================================================
    
                // Onyx Boox Go 6
        BRAND == "onyx" && MODEL == "go6"
        -> Id.ONYX_GO6

               // Onyx Boox Go 7                                                  <<<<<<<
        BRAND == "onyx" && MODEL == "go7"                                         <<<<<<<
        -> Id.ONYX_GO7                                                            <<<<<<<

        // Onyx Boox Go Color 7
        BRAND == "onyx" && MODEL == "gocolor7"
        -> Id.ONYX_GO_COLOR7

@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

Even so, it should be:

ONYX_GO6
ONYX_GO_103
ONYX_GO_COLOR7

ONYX_GO_103 seems to be in the wrong order.

@jadehawk
Copy link
Contributor Author

Even so, it should be:

ONYX_GO6 ONYX_GO_103 ONYX_GO_COLOR7

ONYX_GO_103 seems to be in the wrong order.

I used Windows to sort the list of directories is why I made the change.
sorting

@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

Yes, it can be right.

ONYX_GO_103
ONYX_GO_COLOR7
ONYX_GO6

@Frenzie What convention we use for koreader?

_ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z

or

0, 1, 2, ..., 9, _, A, B, C, ..., Z, a, b, c, ..., z ?

@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

Sorting in the KDE and ls -l show different results.

kde

@jadehawk
Copy link
Contributor Author

Windows vs Linux..

Didn't think I'll sort diffently, interesting.
Wonder what sorting Koreader Devs will favor, my money is on your sorting. (Linux) 😆 🤣

@Frenzie
Copy link
Member

Frenzie commented May 21, 2025

@hugleo

_ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z

I'm inclined to think that one, which I think is also in line with Dolphin and Explorer? Also see https://github.com/koreader/koreader/blob/f1fa4cbfb53871b2c8c03410b34c7801449c0a92/frontend/sort.lua and similar. Mind, you need ls -v for its natural sort which does exactly the reverse:

$ ls -lv
total 0
-rw-rw-r-- 1 frans frans  0 mei 21 09:20  A
-rw-rw-r-- 1 frans frans  0 mei 21 09:21  B
drwxrwxr-x 2 frans frans 40 mei 21 09:22  ONYX_GO6
drwxrwxr-x 2 frans frans 40 mei 21 09:22  ONYX_GO_6
-rw-rw-r-- 1 frans frans  0 mei 21 09:20  a
-rw-rw-r-- 1 frans frans  0 mei 21 09:21  b
-rw-rw-r-- 1 frans frans  0 mei 21 09:36  z6
-rw-rw-r-- 1 frans frans  0 mei 21 09:26  za
-rw-rw-r-- 1 frans frans  0 mei 21 09:27 'z a'
-rw-rw-r-- 1 frans frans  0 mei 21 09:26  z_a
-rw-rw-r-- 1 frans frans  0 mei 21 09:20 ' A'
-rw-rw-r-- 1 frans frans  0 mei 21 09:20 ' a'
-rw-rw-r-- 1 frans frans  0 mei 21 09:20  _A
-rw-rw-r-- 1 frans frans  0 mei 21 09:20  _a

@jadehawk

Windows vs Linux..

I think MS-DOS utilities are often superior to many a Unix utility in user-friendliness. The most egregious example is that mv doesn't prompt whether you want to overwrite without providing a special flag.

jadehawk added 3 commits May 21, 2025 04:26
Restored sort order as discussed (koreader#556 (comment))

_ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z

Using Linux [ls -lv] instead of the Windows sort order.
Restored sort order as discussed (koreader#556 (comment))

_ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z

Using Linux [ls -lv] instead of the Windows sort order.
Restored sort order as discussed (koreader#556 (comment))

_ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z

Using Linux [ls -lv] instead of the Windows sort order.
@jadehawk
Copy link
Contributor Author

@hugleo and @Frenzie

Alright I updated the changes I made restoring the Sort Order, taking the sort order on a linux machine and using "ls -lv" I hope I got it right this time, please review and thank you for the help.

This are my sort results:

sort ls-lv

@Frenzie
Copy link
Member

Frenzie commented May 21, 2025

No, no, I said ls -lv is totally weird in this particular manner. 😅

@jadehawk
Copy link
Contributor Author

Both ls -l and ls -lv game me same result on unraid os. same order as @hugleo example. Same as original order before I moved them.

@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

What @Frenzie says is that you can follow whatever Windows says :)

@jadehawk
Copy link
Contributor Author

What @Frenzie says is that you can follow whatever Windows says :)

This is what happens when you mess with stuff while on a 16 hour shift.

So now that I had a good 3 hour nap and heading back to work, before I make another update here.
I want to confirm that I can update the sort again, this time using the sort I originally started with when I use the Sort Order given by my "Windows 11" machine, Instead of the Sort Order given by "Linix (UnRaid)" machine.
So that I can reference this post on my commit notes.

So:
[A] For Windows.
[B] For Linux.

We are going with [A]
Yes or No

@hugleo & @Frenzie Thank you guys again.

@hugleo
Copy link
Contributor

hugleo commented May 21, 2025

Yes, you can go with option A. Friendly Linux applications like KDE Dolphin file manager use the same sort order as Windows. The weirdness seems with Linux text mode tools.

jadehawk added 2 commits May 21, 2025 13:02
Sorted following same order given by Windows, and as agreed on post: (koreader#556 (comment))
Sorted following same order given by Windows, and as agreed on post: (koreader#556 (comment))
Sorted following same order given by Windows, and as agreed on post: (koreader#556 (comment))
@Frenzie
Copy link
Member

Frenzie commented May 21, 2025

ls sorts differently depending on what you put in LC_ALL btw.

@jadehawk
Copy link
Contributor Author

Done. with the editing.

Thank you ( @Frenzie & @hugleo ) all for your help and patience. Not sure what else happens now, I see changes have been approved, I assume in a few days it might get added to a nightly if all goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants