-
Notifications
You must be signed in to change notification settings - Fork 94
Add Boox Go 7 support #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add ONYX_GO7 device entry and detection Device info: Manufacturer: qualcomm Brand: onyx Model: go7 Device: go7 Product: go7 Hardware: qcom Platform: lito
Add ONYX_GO7 device entry and detection Device info: Manufacturer: qualcomm Brand: onyx Model: go7 Device: go7 Product: go7 Hardware: qcom Platform: lito
Add ONYX_GO7 device entry and detection Device info: Manufacturer: qualcomm Brand: onyx Model: go7 Device: go7 Product: go7 Hardware: qcom Platform: lito
Add ONYX_GO7 device entry and detection Device info: Manufacturer: qualcomm Brand: onyx Model: go7 Device: go7 Product: go7 Hardware: qcom Platform: lito
Fail Syntax Check |
Add ONYX_GO7 device entry and detection Device info: Manufacturer: qualcomm Brand: onyx Model: go7 Device: go7 Product: go7 Hardware: qcom Platform: lito Drivers that Work: Onyx ADB (Lights) Onyx SDK (Lights) Onyx/Qualcomm (E-ink)
Please use this same PR. Do not open an additional PR. |
Copy. Still learning. Apologies. |
The GO6 device was already sorted in the correct order. |
Assumed list was in alphabetical order. My mistake then. Should I return it order:
|
Even so, it should be: ONYX_GO6 ONYX_GO_103 seems to be in the wrong order. |
Yes, it can be right. ONYX_GO_103 @Frenzie What convention we use for koreader? _ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z or 0, 1, 2, ..., 9, _, A, B, C, ..., Z, a, b, c, ..., z ? |
Windows vs Linux.. Didn't think I'll sort diffently, interesting. |
I'm inclined to think that one, which I think is also in line with Dolphin and Explorer? Also see https://github.com/koreader/koreader/blob/f1fa4cbfb53871b2c8c03410b34c7801449c0a92/frontend/sort.lua and similar. Mind, you need
I think MS-DOS utilities are often superior to many a Unix utility in user-friendliness. The most egregious example is that |
Restored sort order as discussed (koreader#556 (comment)) _ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z Using Linux [ls -lv] instead of the Windows sort order.
Restored sort order as discussed (koreader#556 (comment)) _ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z Using Linux [ls -lv] instead of the Windows sort order.
Restored sort order as discussed (koreader#556 (comment)) _ , 0, 1, 2, ..., 9, A, B, C, ..., Z, a, b, c, ..., z Using Linux [ls -lv] instead of the Windows sort order.
No, no, I said |
Both ls -l and ls -lv game me same result on unraid os. same order as @hugleo example. Same as original order before I moved them. |
What @Frenzie says is that you can follow whatever Windows says :) |
This is what happens when you mess with stuff while on a 16 hour shift. So now that I had a good 3 hour nap and heading back to work, before I make another update here. So: We are going with [A] |
Yes, you can go with option A. Friendly Linux applications like KDE Dolphin file manager use the same sort order as Windows. The weirdness seems with Linux text mode tools. |
Sorted following same order given by Windows, and as agreed on post: (koreader#556 (comment))
Sorted following same order given by Windows, and as agreed on post: (koreader#556 (comment))
Sorted following same order given by Windows, and as agreed on post: (koreader#556 (comment))
|
Add ONYX_GO7 device entry and detection
Device info:
Manufacturer: qualcomm
Brand: onyx
Model: go7
Device: go7
Product: go7
Hardware: qcom
Platform: lito
Drivers that Work:
Onyx ADB (Lights)
Onyx SDK (Lights)
Onyx/Qualcomm (E-ink)
test.log
This change is