Skip to content

fix: Json configuration not applying when using custom HttpClient #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Json configuration not applying when using custom HttpClient #983

wants to merge 1 commit into from

Conversation

JellyBrick
Copy link

No description provided.

@JellyBrick
Copy link
Author

Any updates?

@lukellmann
Copy link
Member

i will take a look later

@lukellmann
Copy link
Member

We actually don't use the ContentNegotiation plugin, right @DRSchlaubi? The only thing it seems to do for us is adding an Accept: application/json header to our requests, which is probably useless. So we might instead just remove this configuration of the ContentNegotiation plugin.

@DRSchlaubi
Copy link
Member

That's correct we don't use it as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JellyBrick @lukellmann @DRSchlaubi