Continue adding node even if checks fail #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #32 |
Member
|
I am not sure whether this is the right call, since the version check should stop connecting to the node, maybe we can move it to after the ws connect, however that wouldn't be ideal either. Maybe add a config flag for it? |
Contributor
Author
|
It didn't occur to me it throws an exception on purpose. What you could do is apply the same retry strategy to the version check I think you should also put some thought into what happens if a node is rejected. Currently if a node is rejected, it just seems to linger in an inactive state in the AbstractLavakord instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps you have a more elaborate strategy in mind. This is enough to do the trick for me at least.