Fix : Use Vaadin flow CheckboxGroup component for Boolean field to simplify the field manipulation and fix the focus issues when using the keyboard to browse a form's different fields [APPS-02BL] #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplify the field manipulation and fix the focus issues when using the keyboard to browse a form different fields [APPS-02BL]
…e grid component [APPS-02BL]
sebai-dhia
suggested changes
Nov 8, 2024
Contributor
sebai-dhia
left a comment
sebai-dhia
left a comment
There was a problem hiding this comment.
Code Review: FAIL
Indentation in the getBooleanValue function of the BooleanField class.
Indentation in the getBooleanValue function of the GridEditorBooleanField class.
Tests: FAIL
Two behaviors need to be corrected when navigating via the Tab key:
-
When navigating between fields in a group of checkboxes, it is impossible to directly select one of the options by pressing the Enter key. An event listener should be added to detect the click and change the state of the button.
-
When navigating in reverse, when the cursor moves from the second option to the first, it immediately jumps back to the first field in the block and then navigates to the second field, which is incorrect.
sebai-dhia
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Vaadin flow CheckboxGroup component for Boolean field to simplify the field manipulation and fix the focus issues when using the keyboard to browse a form's different fields
This PR allows to shift the focus inside the checkbox group using the TAB key and to select / deselect the boolean field's values using the SPACE key.