Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: modify cpu and memory quantity formats and scales #675

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Oct 8, 2022

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Change pod's cpu quantity to MilliQuantity in order to calculate runtimeQuota correctly, change memory's format from DecimalSI to BinarySI, fix UT.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and hormes October 8, 2022 10:53
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 68.85% // Head: 68.86% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (790a5dc) compared to base (f89f000).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   68.85%   68.86%   +0.01%     
==========================================
  Files         204      204              
  Lines       22962    22977      +15     
==========================================
+ Hits        15811    15824      +13     
- Misses       6052     6054       +2     
  Partials     1099     1099              
Flag Coverage Δ
unittests 68.86% <88.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/elasticquota/core/runtime_quota_calculator.go 88.23% <86.20%> (-0.09%) ⬇️
.../scheduler/plugins/elasticquota/core/quota_info.go 85.16% <100.00%> (ø)
...ticquota/core/scale_minquota_when_over_root_res.go 100.00% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️
...duler/plugins/elasticquota/quota_overuse_revoke.go 80.23% <0.00%> (+1.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xulinfei1996 xulinfei1996 changed the title koord-scheduler: modify cpu and memory quantity formats and scles koord-scheduler: modify cpu and memory quantity formats and scales Oct 8, 2022
@xulinfei1996 xulinfei1996 force-pushed the quantity branch 5 times, most recently from 9b0d836 to 2dc1a57 Compare October 9, 2022 02:27
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Oct 10, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: buptcozy, eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c70a2e3 into koordinator-sh:main Oct 10, 2022
@xulinfei1996 xulinfei1996 deleted the quantity branch October 13, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants