Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler:support multi gpu share #2127

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

AdrianMachao
Copy link
Contributor

@AdrianMachao AdrianMachao commented Jul 5, 2024

Ⅰ. Describe what this PR does

support multi gpu share

Ⅱ. Does this pull request fix one issue?

#2097

Ⅲ. Describe how to verify it

use gpushare resource follow proposal

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@AdrianMachao AdrianMachao force-pushed the feat/MultiGPU branch 2 times, most recently from aa914c5 to d60020d Compare July 5, 2024 08:54
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 71.98068% with 58 lines in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (4a182a1) to head (675688a).
Report is 6 commits behind head on main.

Files Patch % Lines
...g/webhook/pod/validating/verify_device_resource.go 70.12% 17 Missing and 6 partials ⚠️
pkg/scheduler/plugins/deviceshare/utils.go 59.61% 19 Missing and 2 partials ⚠️
pkg/webhook/pod/mutating/device_resource_spec.go 87.71% 5 Missing and 2 partials ⚠️
pkg/webhook/pod/validating/validating_handler.go 33.33% 2 Missing and 2 partials ⚠️
pkg/webhook/pod/mutating/mutating_handler.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2127      +/-   ##
==========================================
- Coverage   67.87%   67.86%   -0.01%     
==========================================
  Files         441      443       +2     
  Lines       41611    41920     +309     
==========================================
+ Hits        28242    28448     +206     
- Misses      10937    11017      +80     
- Partials     2432     2455      +23     
Flag Coverage Δ
unittests 67.86% <71.98%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdrianMachao AdrianMachao force-pushed the feat/MultiGPU branch 3 times, most recently from e33c0a9 to 81f2016 Compare July 13, 2024 07:16
@AdrianMachao
Copy link
Contributor Author

AdrianMachao commented Jul 13, 2024

@FillZpp @jasonliu747 @ZiMengSheng PTAL.

@AdrianMachao AdrianMachao force-pushed the feat/MultiGPU branch 3 times, most recently from 290b405 to b636506 Compare July 18, 2024 06:20
@ZiMengSheng
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Contributor

/approve

pkg/features/features.go Outdated Show resolved Hide resolved
@koordinator-bot koordinator-bot bot removed the lgtm label Jul 23, 2024
@AdrianMachao
Copy link
Contributor Author

@hormes done

@AdrianMachao
Copy link
Contributor Author

/assign @FillZpp @jasonliu747 @buptcozy

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 24, 2024
@AdrianMachao
Copy link
Contributor Author

Is there any other problems? @hormes

Signed-off-by: machao <986292120@qq.com>
@hormes
Copy link
Member

hormes commented Jul 30, 2024

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8c7b20d into koordinator-sh:main Jul 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants