-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler:support multi gpu share #2127
scheduler:support multi gpu share #2127
Conversation
aa914c5
to
d60020d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
- Coverage 67.87% 67.86% -0.01%
==========================================
Files 441 443 +2
Lines 41611 41920 +309
==========================================
+ Hits 28242 28448 +206
- Misses 10937 11017 +80
- Partials 2432 2455 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/slo-controller/noderesource/plugins/gpudeviceresource/plugin.go
Outdated
Show resolved
Hide resolved
d60020d
to
7e3031b
Compare
e33c0a9
to
81f2016
Compare
@FillZpp @jasonliu747 @ZiMengSheng PTAL. |
290b405
to
b636506
Compare
/lgtm |
/approve |
b636506
to
cb30521
Compare
@hormes done |
/assign @FillZpp @jasonliu747 @buptcozy |
/lgtm |
pkg/slo-controller/noderesource/plugins/gpudeviceresource/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/gpudeviceresource/plugin.go
Outdated
Show resolved
Hide resolved
cb30521
to
8ef73b8
Compare
8ef73b8
to
7b0ebb2
Compare
Is there any other problems? @hormes |
dfa35a0
to
b8aa2fa
Compare
pkg/slo-controller/noderesource/plugins/gpudeviceresource/plugin.go
Outdated
Show resolved
Hide resolved
Signed-off-by: machao <986292120@qq.com>
b8aa2fa
to
675688a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, ZiMengSheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
support multi gpu share
Ⅱ. Does this pull request fix one issue?
#2097
Ⅲ. Describe how to verify it
use gpushare resource follow proposal
Ⅳ. Special notes for reviews
V. Checklist
make test