koordetector: make koordetector able to build #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwzhang0107
reviewed
Mar 7, 2023
songtao98
force-pushed
the
build_koordetector
branch
9 times, most recently
from
2e8d93c to
77c5a0d
Compare
…uccess Signed-off-by: songtao98 <songtao2603060@gmail.com>
songtao98
force-pushed
the
build_koordetector
branch
from
77c5a0d to
3fae2df
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit into main branch has a dependency conflict, which makes interference manager build failed. This PR fix it by replace related modules compulsively to correct version.
This PR also rewrite
statesinformerin koordinator. This is because koordetector plan to deprecatemetriccachein koordinator, instead using tsdb to cache metrics in the future. Also there are redundant clients that koordinator's statesinformer relies on, such as topologyclient, etc. We also need to delete them in koordetector.After these modifications, this PR adds dockerfile and makefile for koordetector component to build.