specify required fields #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgwozdz
reviewed
Aug 2, 2021
| import { version } from '../package.json'; | ||
| import { getDataStreamDcatAp201 } from './dcat-ap'; | ||
| import * as config from 'config'; | ||
| import { requiredFields } from './dcat-ap/dcat-dataset'; |
There was a problem hiding this comment.
So the required fields stay the same across all requests?
There was a problem hiding this comment.
That's right. Right now the dependencies are not configurable and this is the comprehensive list.
rgwozdz
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API gives us the ability to specify only a subset of dataset info to come back over the wire. This PR takes advantage of that to reduce data transfer overhead.