add route handler #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
commented
Jul 29, 2021
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "arcgisPortal": "https://www.arcgis.com" | |||
There was a problem hiding this comment.
Not sure on the naming here...
| }); | ||
|
|
||
| it('handles a DCAT request', async () => { | ||
| await request(app) |
There was a problem hiding this comment.
Opted for the supertest route to flex the handler as realistically as possible.
drewdaemon
commented
Jul 29, 2021
|
|
||
| const siteUrl = 'https://foobar.hub.arcgis.com' | ||
| const orgTitle = 'My Fun Org' | ||
| const portalUrl = 'https://my-fun-org.maps.arcgis.com' | ||
|
|
||
| describe('DcatDataset', () => { | ||
| it('Dataset props come from right places', function() { | ||
| const dataset = new DcatDataset(datasetFromApi.attributes, portalUrl, orgTitle, siteUrl) |
There was a problem hiding this comment.
I thought we got the whole response back from Mark's searchContent Hub.js function, but we actually just get the attributes.
drewdaemon
commented
Jul 29, 2021
| @@ -11,7 +11,7 @@ module.exports = { | |||
| "json", | |||
| "node", | |||
| ], | |||
| testRegex: '(/__tests__/.*|(\\.|/)(test|spec))\\.(ts|js)x?$', | |||
| testRegex: '(/__tests__/.src|(\\.|/)(test|spec))\\.(ts|js)x?$', | |||
There was a problem hiding this comment.
Jest was looking in the ./build folder, so I scoped this down.
rgwozdz
reviewed
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires the formatting logic up to the AGO API, and the datasets from the Hub Search API.