b/2880 added fallback logic #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2880 - It appears that during the migration, handling of fallback logic (path hierarchies in adlib terms) was not implemented when converting adlib dependency specifications to API fields. This re-introduces it. Note that the adlib spec allows for the last field of a path hierarchy to be either a valid Hub API field or a literal (see here under
Path Hierarchies with Defaults) but there is no syntax to differentiate them. This implementation makes a request for valid fields, such that if the last field is a valid API field, it is used in the search request. Otherwise, it is not.