Skip to content

F/2342 add id query param #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021
Merged

F/2342 add id query param #11

merged 4 commits into from
Nov 23, 2021

Conversation

drspacemanphd
Copy link
Contributor

@drspacemanphd drspacemanphd commented Nov 22, 2021

2342 as a prerequisite for previewing the dcat-ap feed, the id and dcat query params should be able to be parsed.

@drspacemanphd drspacemanphd self-assigned this Nov 22, 2021
Copy link
Collaborator

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remember that you'll also have to add a dcatConfig query param in order to achieve the preview functionality.

@drspacemanphd drspacemanphd merged commit 1829eb7 into main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants