Skip to content

fix(top-bar): properly align end container (#DS-3886) #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(top-bar): properly align end container (#DS-3886) #879

wants to merge 2 commits into from
+324 −319

Conversation

NikGurev
Copy link
Contributor

Summary

put overflow-items inside top-bar-container instead of merging them. It will resolve the hiding logic work along with justify-contend: end.

<div kbqOverflowItems KbqTopBarContainer placement="end"></div>

to

<div KbqTopBarContainer placement="end">
       <div kbqOverflowItems></div>
</div>

@NikGurev NikGurev requested a review from artembelik June 28, 2025 18:30
@NikGurev NikGurev self-assigned this Jun 28, 2025
@NikGurev NikGurev requested a review from lskramarov as a code owner June 28, 2025 18:30
@NikGurev NikGurev added the bug Something isn't working label Jun 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0fa25fb):

https://koobiq-next--prs-879-nvy7iwp4.web.app

(expires Sat, 05 Jul 2025 08:46:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

artembelik
artembelik reviewed Jun 30, 2025
View reviewed changes
packages/components/top-bar/top-bar.scss Outdated
}

// apply margin if the last item needs to be alwaysVisible
&:last-of-type:is([aria-hidden='false']) + .kbq-overflow-items-result {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай селектор добавим kbq-overflow-item_always-visible и будем на него ориентироваться

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lskramarov lskramarov lskramarov approved these changes

@artembelik artembelik artembelik approved these changes

Assignees

@NikGurev NikGurev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikGurev @lskramarov @artembelik