Skip to content

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik self-assigned this Nov 21, 2025
Copilot AI review requested due to automatic review settings November 21, 2025 13:00
Copilot finished reviewing on behalf of artembelik November 21, 2025 13:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the AG Grid dependencies from version 30 to version 34, updating both the core grid libraries and the Koobiq theme package. The changes include necessary code migrations to adapt to AG Grid v34's new modular architecture and updated selection API.

Key Changes:

  • Upgraded @koobiq/ag-grid-angular-theme from ^30.2.0 to ^34.0.0
  • Upgraded ag-grid-angular from ^30.2.1 to ^34.3.1 and ag-grid-community from ^30.2.1 to ^34.3.1
  • Migrated row selection from deprecated string-based API to new RowSelectionOptions object pattern
  • Added explicit module registration using ModuleRegistry.registerModules([AllCommunityModule])
  • Removed manual checkbox column definitions in favor of auto-generated selection columns

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Updated dependency resolution for AG Grid packages to v34, including new peer dependencies and checksums
package.json Updated AG Grid dependencies to v34 versions in root package.json
apps/docs/src/assets/stackblitz/package.json Updated AG Grid dependencies for StackBlitz examples
packages/docs-examples/components/content-panel/content-panel-with-grid/content-panel-with-grid-example.ts Migrated to AG Grid v34 API with module registration, RowSelectionOptions, and auto-generated selection column
packages/docs-examples/components/ag-grid/ag-grid-row-dragging/ag-grid-row-dragging-example.ts Migrated to AG Grid v34 API with module registration, RowSelectionOptions, and auto-generated selection column
packages/docs-examples/components/ag-grid/ag-grid-overview/ag-grid-overview-example.ts Migrated to AG Grid v34 API with module registration, RowSelectionOptions, and auto-generated selection column

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@artembelik artembelik requested a review from NikGurev November 21, 2025 13:03
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Visit the preview URL for this PR (updated for commit cf92a69):

https://koobiq-next--prs-1135-a1hexb51.web.app

(expires Wed, 26 Nov 2025 13:11:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev
Copy link
Contributor

секцию "Установка" надо обновить.
Кажется, ты говорил, что с 30 версией не совместимо

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants