Skip to content

Conversation

@artembelik
Copy link
Contributor

@artembelik artembelik commented Nov 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 19, 2025 14:03
@artembelik artembelik added the bug Something isn't working label Nov 19, 2025
@artembelik artembelik requested a review from NikGurev November 19, 2025 14:03
Copilot finished reviewing on behalf of artembelik November 19, 2025 14:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances SSR (Server-Side Rendering) support by wrapping browser-specific event listener registrations in afterNextRender() to ensure they only execute in browser environments, preventing SSR runtime errors.

  • Uses Angular's afterNextRender() to defer event listener setup until client-side rendering
  • Removes conditional logic that checked for window availability before adding event listeners
  • Maintains ngZone.runOutsideAngular() for performance optimization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/components/navbar/navbar-item.component.ts Wraps keyboard event listener registration in afterNextRender() for SSR compatibility
packages/components/autocomplete/autocomplete-trigger.directive.ts Wraps blur event listener registration in afterNextRender() for SSR compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Visit the preview URL for this PR (updated for commit 314f550):

https://koobiq-next--prs-1129-e2h63600.web.app

(expires Tue, 25 Nov 2025 07:46:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik self-assigned this Nov 20, 2025
@lskramarov
Copy link
Contributor

DS-3964 - закрыта в прошлом спринте

@artembelik artembelik merged commit 4aa1066 into main Nov 21, 2025
8 checks passed
@artembelik artembelik deleted the fix/DS-3964-v2 branch November 21, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants