fix(modal,sidepanel): content body top padding (#DS-2557) #1128
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes content body top padding issues in modal and sidepanel components by adding a minimal 1px top padding. This padding prevents CSS margin collapse between the content body and its child elements, ensuring consistent spacing.
- Changed modal content top padding from
0to1pxvia CSS variable - Added 1px top padding to sidepanel body element
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/components/modal/modal-tokens.scss | Updated --kbq-modal-size-content-padding-top CSS variable from 0 to 1px to prevent margin collapse |
| packages/components/sidepanel/sidepanel.scss | Added padding-top: 1px to .kbq-sidepanel-body to prevent margin collapse |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 66be0ee): https://koobiq-next--prs-1128-c5szk7fe.web.app (expires Mon, 24 Nov 2025 13:26:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
| flex-direction: column; | ||
| min-height: 0; | ||
|
|
||
| padding-top: 1px; |
There was a problem hiding this comment.
??
| padding-top: 1px; | |
| padding-top: var(--kbq-sidepanel-size-content-padding-bottom); |
|
Еще поповер. |
| --kbq-modal-size-close-button-margin-left: var(--kbq-size-s); | ||
| --kbq-modal-size-content-padding-horizontal: var(--kbq-size-xxl); | ||
| --kbq-modal-size-content-padding-top: 0; | ||
| --kbq-modal-size-content-padding-top: 1px; |
There was a problem hiding this comment.
нужно добавить комментарий для чего этот паддинг в 1px
|
в поповере еще можно |
|
No description provided.